Skip to content

Conversation

@byronkenoly
Copy link

@byronkenoly byronkenoly commented Nov 21, 2022

Description

Three new files in src folder: ForgotPassword.tsx, forgotPassword.css, spaceYaTechLogo.svg

  • Created ForgotPassword component which is in the file ForgotPassword.tsx
  • The file used to style it is forgotPassword.css
  • SpaceYaTech logo added - exported from a figma file

Modified two files: public/index.html, src/index.tsx

  • Copied and embedded Poppins fonts(specified in figma file) from google fonts in head tag of index.html
  • imported ForgotPassword component in index.tsx file to render it in the browser

Eye icon in the password input field not yet added

No additional dependencies used for these additions and modifications

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Rendered the component in a web browser. Everything looks OK.

Test Configuration:

  • Firmware version: N/A
  • Hardware: N/A
  • Toolchain: N/A
  • SDK: N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@daveclinton daveclinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byronkenoly we are using Tailwind CSS for our styling

Copy link
Contributor

@daveclinton daveclinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byronkenoly check contribution guidelines for reference on the github workflow. You are not supposed to fork the repository.

@byronkenoly
Copy link
Author

@byronkenoly we are using Tailwind CSS for our styling

OK let me style it using tailwind

@byronkenoly
Copy link
Author

@byronkenoly check contribution guidelines for reference on the github workflow. You are not supposed to fork the repository.

Cool. I'm working on it

@jumalaw98
Copy link
Contributor

hello @byronkenoly did you managed to counter the changes?
or a you experiencing difficulties?

@jumalaw98
Copy link
Contributor

@daveclinton was the request, requested changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants