Skip to content

Commit c9586f5

Browse files
committed
Use static module requires because JPMS is just awful
1 parent e10ac70 commit c9586f5

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/modularity/java/module-info.java

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,14 @@
2626
/**
2727
* Mixin module declaration
2828
*/
29-
@SuppressWarnings("module") // Suppress the warnings about gson and gson below
29+
@SuppressWarnings("module") // Suppress the warnings about gson and gson below. Damn gsons, you ruined gson!
3030
module org.spongepowered.mixin {
3131

3232
//
3333
// Actual modules we depend on
3434
//
35-
requires transitive cpw.mods.modlauncher;
36-
requires cpw.mods.securejarhandler;
3735
requires transitive java.compiler;
3836
requires transitive java.instrument;
39-
requires transitive org.apache.logging.log4j;
40-
requires org.apache.logging.log4j.core;
4137
requires transitive org.objectweb.asm;
4238
requires transitive org.objectweb.asm.commons;
4339
requires transitive org.objectweb.asm.tree;
@@ -46,11 +42,19 @@
4642
requires java.logging;
4743

4844
//
49-
// Automatic modules we depend on
45+
// Modules we require for compilation but don't necessarily need at runtime
5046
//
51-
requires jopt.simple;
52-
requires guava;
53-
requires gson;
47+
requires static org.apache.logging.log4j.core;
48+
requires static transitive cpw.mods.modlauncher;
49+
requires static cpw.mods.securejarhandler;
50+
requires static transitive org.apache.logging.log4j;
51+
52+
//
53+
// Automatic modules we depend on, using static to avoid the forward compatibility mess
54+
//
55+
requires static jopt.simple;
56+
requires static guava;
57+
requires static gson;
5458

5559
//
5660
// Exports

0 commit comments

Comments
 (0)