Fix axis typing.

Author: SuuperW

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -1385,48 +1385,34 @@ public void EditAnalogProgrammatically(KeyEventArgs e)
 			}
 
 			string prevTyped = _axisTypedValue;
+			AxisSpec axis = ControllerType.Axes[AxisEditColumn];
 
-			var range = ControllerType.Axes[AxisEditColumn];
-
-			// feos: typing past max digits overwrites existing value, not touching the sign
-			// but doesn't handle situations where the range is like -50 through 100, where minimum is negative and has less digits
-			// it just uses 3 as maxDigits there too, leaving room for typing impossible values (that are still ignored by the game and then clamped)
-			int maxDigits = range.MaxDigits;
-			int curDigits = _axisTypedValue.Length;
-			string curMinus;
-			if (_axisTypedValue.StartsWith('-'))
+			int charToType = -1;
+			if (e.KeyCode is >= Keys.D0 and <= Keys.D9)
 			{
-				curDigits -= 1;
-				curMinus = "-";
+				charToType = e.KeyCode - Keys.D0;
 			}
-			else
+			else if (e.KeyCode is >= Keys.NumPad0 and <= Keys.NumPad9)
 			{
-				curMinus = "";
+				charToType = e.KeyCode - Keys.NumPad0;
 			}
 
-			if (e.KeyCode is >= Keys.D0 and <= Keys.D9)
+			if (charToType != -1)
 			{
-				if (curDigits >= maxDigits)
+				if ((_axisTypedValue.StartsWith('-') && _axisTypedValue.Length < axis.Min.ToString().Length)
+					|| (!_axisTypedValue.StartsWith('-') && _axisTypedValue.Length < axis.Max.ToString().Length))
 				{
-					_axisTypedValue = curMinus;
+					_axisTypedValue += charToType;
 				}
-
-				_axisTypedValue += e.KeyCode - Keys.D0;
 			}
-			else if (e.KeyCode is >= Keys.NumPad0 and <= Keys.NumPad9)
+			else if (e.KeyCode is Keys.OemMinus or Keys.Subtract)
 			{
-				if (curDigits >= maxDigits)
+				if (axis.Min < 0)
 				{
-					_axisTypedValue = curMinus;
+					_axisTypedValue = _axisTypedValue.StartsWith('-')
+						? _axisTypedValue.Substring(startIndex: 1)
+						: $"-{_axisTypedValue}";
 				}
-
-				_axisTypedValue += e.KeyCode - Keys.NumPad0;
-			}
-			else if (e.KeyCode is Keys.OemMinus or Keys.Subtract)
-			{
-				_axisTypedValue = _axisTypedValue.StartsWith('-')
-					? _axisTypedValue.Substring(startIndex: 1)
-					: $"-{_axisTypedValue}";
 			}
 			else if (e.KeyCode == Keys.Back)
 			{
@@ -1458,13 +1444,13 @@ public void EditAnalogProgrammatically(KeyEventArgs e)
 				int value;
 				if (_axisTypedValue.Length is 0)
 				{
-					value = ControllerType.Axes[AxisEditColumn].Neutral;
+					value = axis.Neutral;
 				}
 				else
 				{
 					if (int.TryParse(_axisTypedValue, NumberStyles.Float, NumberFormatInfo.InvariantInfo, out value)) // String "-" can't be parsed.
 					{
-						value = value.ConstrainWithin(range.Range);
+						value = value.ConstrainWithin(axis.Range);
 					}
 					else
 					{