Await users before inserting posts

Author: kevin-dp

packages/db-collection-e2e/src/suites/moves.suite.ts

@@ -118,6 +118,21 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
       })
     }
 
+    // Helper to wait for users to be synced to Electric/TanStack DB
+    async function waitForUsersSynced(
+      userIds: Array<string>,
+      timeout: number = 10000,
+    ) {
+      // Use eager collection since it continuously syncs all data
+      const usersCollection = config.collections.eager.users
+      await waitFor(() => {
+        return userIds.every((userId) => usersCollection.has(userId))
+      }, {
+        timeout,
+        message: `Users ${userIds.join(', ')} did not sync to collection`,
+      })
+    }
+
     // Helper function to run all tests for a given sync mode
     function runTestsForSyncMode(syncMode: SyncMode) {
       describe(`${syncMode} mode`, () => {
@@ -167,6 +182,10 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for all 3 users to be synced to Electric before inserting posts
+          // This ensures the subquery in the WHERE clause can properly evaluate
+          await waitForUsersSynced([userId1, userId2, userId3])
+
           // Insert posts for these users
           const postId1 = randomUUID()
           const postId2 = randomUUID()
@@ -251,6 +270,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -305,6 +327,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -358,6 +383,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -413,6 +441,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -469,6 +500,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -521,6 +555,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
+          // Wait for user to be synced to Electric before inserting post
+          await waitForUsersSynced([userId])
+
           // Insert post for this user
           const postId = randomUUID()
           await config.mutations.insertPost({
@@ -610,7 +647,9 @@ export function createMovesTestSuite(getConfig: () => Promise<TagsTestConfig>) {
             deletedAt: null,
           })
 
-          await new Promise((resolve) => setTimeout(resolve, 1000))
+          // Wait for all 3 users to be synced to Electric before inserting posts
+          // This ensures the subquery in the WHERE clause can properly evaluate
+          await waitForUsersSynced([userId1, userId2, userId3])
 
           // Insert posts for these users
           const postId1 = randomUUID()