Skip to content

Conversation

@antoKeinanen
Copy link
Contributor

@antoKeinanen antoKeinanen commented Jun 25, 2024

Currently the hero section's discord live view always shows current date as the message's timestamp. This pr fixes it by showing the logged timestamp collected by discord-chat-dump.

@vercel
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testausserveri-fi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 11:12am

@theisoj
Copy link
Member

theisoj commented Jun 25, 2024

looks good to me!

@Esinko
Copy link
Member

Esinko commented Nov 11, 2024

@antoKeinanen merge has conflicts, when fixed I'll make sure this is merged.

@antoKeinanen
Copy link
Contributor Author

@antoKeinanen merge has conflicts, when fixed I'll make sure this is merged.

Resolved the merge conflict

@Esinko
Copy link
Member

Esinko commented Nov 23, 2024

@ahnl Do we want this to be a thing? PR looks good.
Basically this will make the message's timestamp accurate in the background.

@ahnl
Copy link
Member

ahnl commented Nov 23, 2024

I believe it would be better to hide the timestamp altogether, as it is not particularly relevant and introduces several issues:

  • Over time, the displayed timestamps will appear increasingly outdated—for example, in 2025 or 2026, we’ll still be showing messages from 2024, which might leave a poor impression.
  • On mobile, the timestamp in the current implementation and this PR overflows to the next line, which negatively impacts the design (this behavior doesn't occur in Discord itself).

Given these concerns, I’m not convinced this PR should be merged as is. Instead, I think #128 (updating the phone graphic to remove the old notch) should be prioritized at some point—or alternatively, we could consider using a more generic, notch-less phone design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants