Merge remote-tracking branch 'origin/main' into feature/ai-autocomplete

Author: YousefED

CHANGELOG.md

@@ -1,3 +1,34 @@
+## 0.42.3 (2025-11-19)
+
+### 🩹 Fixes
+
+- disallow access to the `domElement` or `isFocused` if the editor is unmounted ([#2187](https://github.com/TypeCellOS/BlockNote/pull/2187))
+
+### ❤️ Thank You
+
+- Nick Perez
+
+## 0.42.2 (2025-11-19)
+
+### 🩹 Fixes
+
+- put back mounting system ([#2183](https://github.com/TypeCellOS/BlockNote/pull/2183))
+
+### ❤️ Thank You
+
+- Nick Perez
+
+## 0.42.1 (2025-11-18)
+
+### 🩹 Fixes
+
+- do not error on invalid `backgroundColor` or `textColor` #2176 ([#2179](https://github.com/TypeCellOS/BlockNote/pull/2179), [#2176](https://github.com/TypeCellOS/BlockNote/issues/2176))
+- remove dependency array from comments re-rendering ([#2177](https://github.com/TypeCellOS/BlockNote/pull/2177))
+
+### ❤️ Thank You
+
+- Nick Perez
+
 ## 0.42.0 (2025-11-11)
 
 ### 🚀 Features

docs/package.json

@@ -56,7 +56,7 @@
     "@shikijs/langs-precompiled": "^3.2.1",
     "@shikijs/themes": "^3.2.1",
     "@shikijs/types": "^3.2.1",
-    "@tiptap/core": "^3.10.2",
+    "@tiptap/core": "^3.11.0",
     "@uppy/core": "^3.13.1",
     "@uppy/dashboard": "^3.9.1",
     "@uppy/drag-drop": "^3.1.1",

examples/08-extensions/01-tiptap-arrow-conversion/.bnexample.json

@@ -5,6 +5,6 @@
   "tags": ["Extension"],
   "pro": true,
   "dependencies": {
-    "@tiptap/core": "^3.10.2"
+    "@tiptap/core": "^3.11.0"
   }
 }

examples/08-extensions/01-tiptap-arrow-conversion/package.json

@@ -21,7 +21,7 @@
     "@mantine/utils": "^6.0.22",
     "react": "^19.2.0",
     "react-dom": "^19.2.0",
-    "@tiptap/core": "^3.10.2"
+    "@tiptap/core": "^3.11.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.2",

packages/ariakit/package.json

@@ -11,7 +11,7 @@
     "directory": "packages/ariakit"
   },
   "license": "MPL-2.0",
-  "version": "0.42.0",
+  "version": "0.42.3",
   "files": [
     "dist",
     "types",
@@ -57,8 +57,8 @@
   },
   "dependencies": {
     "@ariakit/react": "^0.4.19",
-    "@blocknote/core": "0.42.0",
-    "@blocknote/react": "0.42.0"
+    "@blocknote/core": "0.42.3",
+    "@blocknote/react": "0.42.3"
   },
   "devDependencies": {
     "@types/react": "^19.2.2",

packages/code-block/package.json

@@ -9,7 +9,7 @@
     "directory": "packages/code-block"
   },
   "license": "MPL-2.0",
-  "version": "0.42.0",
+  "version": "0.42.3",
   "files": [
     "dist",
     "types",
@@ -49,7 +49,7 @@
     "test-watch": "vitest watch"
   },
   "dependencies": {
-    "@blocknote/core": "0.42.0",
+    "@blocknote/core": "0.42.3",
     "@shikijs/core": "^3.13.0",
     "@shikijs/engine-javascript": "^3.13.0",
     "@shikijs/langs": "^3.13.0",

packages/core/package.json

@@ -11,7 +11,7 @@
     "directory": "packages/core"
   },
   "license": "MPL-2.0",
-  "version": "0.42.0",
+  "version": "0.42.3",
   "files": [
     "dist",
     "types",
@@ -86,7 +86,7 @@
   "dependencies": {
     "@emoji-mart/data": "^1.2.1",
     "@shikijs/types": "3.13.0",
-    "@tiptap/core": "^3.10.2",
+    "@tiptap/core": "^3.11.0",
     "@tiptap/extension-bold": "^3.7.2",
     "@tiptap/extension-code": "^3.7.2",
     "@tiptap/extension-gapcursor": "^3.7.2",
@@ -98,7 +98,7 @@
     "@tiptap/extension-strike": "^3.7.2",
     "@tiptap/extension-text": "^3.7.2",
     "@tiptap/extension-underline": "^3.7.2",
-    "@tiptap/pm": "^3.10.2",
+    "@tiptap/pm": "^3.11.0",
     "emoji-mart": "^5.6.0",
     "fast-deep-equal": "^3.1.3",
     "hast-util-from-dom": "^5.0.1",
@@ -107,7 +107,7 @@
     "prosemirror-model": "^1.25.4",
     "prosemirror-state": "^1.4.4",
     "prosemirror-tables": "^1.8.1",
-    "prosemirror-transform": "^1.10.4",
+    "prosemirror-transform": "^1.10.5",
     "prosemirror-view": "^1.41.3",
     "rehype-format": "^5.0.1",
     "rehype-parse": "^9.0.1",

packages/core/src/editor/BlockNoteEditor.test.ts

@@ -120,7 +120,7 @@ it("onMount and onUnmount", async () => {
   expect(unmounted).toBe(false);
   editor.unmount();
   // expect the unmount event to not have been triggered yet, since it waits 2 ticks
-  expect(unmounted).toBe(false);
+  // expect(unmounted).toBe(false);
   // wait 3 ticks to ensure the unmount event is triggered
   await new Promise((resolve) => setTimeout(resolve, 3));
   expect(mounted).toBe(true);

packages/core/src/editor/BlockNoteEditor.ts

@@ -1054,40 +1054,14 @@ export class BlockNoteEditor<
    * @warning Not needed to call manually when using React, use BlockNoteView to take care of mounting
    */
   public mount = (element: HTMLElement) => {
-    if (
-      // If the editor is scheduled for destruction, and
-      this.scheduledDestructionTimeout &&
-      // If the editor is being remounted to the same element as the one which is scheduled for destruction,
-      // then just cancel the destruction timeout
-      this.prosemirrorView.dom === element
-    ) {
-      clearTimeout(this.scheduledDestructionTimeout);
-      this.scheduledDestructionTimeout = undefined;
-      return;
-    }
-
     this._tiptapEditor.mount({ mount: element });
   };
 
-  /**
-   * Timeout to schedule the {@link unmount}ing of the editor.
-   */
-  private scheduledDestructionTimeout:
-    | ReturnType<typeof setTimeout>
-    | undefined = undefined;
-
   /**
    * Unmount the editor from the DOM element it is bound to
    */
   public unmount = () => {
-    // Due to how React's StrictMode works, it will `unmount` & `mount` the component twice in development mode.
-    // This can result in the editor being unmounted mid-rendering the content of node views.
-    // To avoid this, we only ever schedule the `unmount`ing of the editor when we've seen whether React "meant" to actually unmount the editor (i.e. not calling mount one tick later).
-    // So, we wait two ticks to see if the component is still meant to be unmounted, and if not, we actually unmount the editor.
-    this.scheduledDestructionTimeout = setTimeout(() => {
-      this._tiptapEditor.unmount();
-      this.scheduledDestructionTimeout = undefined;
-    }, 1);
+    this._tiptapEditor.unmount();
   };
 
   /**
@@ -1108,10 +1082,16 @@ export class BlockNoteEditor<
   }
 
   public get domElement() {
+    if (this.headless) {
+      return undefined;
+    }
     return this.prosemirrorView?.dom as HTMLDivElement | undefined;
   }
 
   public isFocused() {
+    if (this.headless) {
+      return false;
+    }
     return this.prosemirrorView?.hasFocus() || false;
   }
 
@@ -1699,7 +1679,7 @@ export class BlockNoteEditor<
       ignoreQueryLength?: boolean;
     },
   ) {
-    if (!this.prosemirrorView) {
+    if (!this.prosemirrorView || this.headless) {
       return;
     }
 

packages/dev-scripts/package.json

@@ -8,7 +8,7 @@
     "directory": "packages/dev-scripts"
   },
   "license": "MPL-2.0",
-  "version": "0.42.0",
+  "version": "0.42.3",
   "description": "",
   "type": "module",
   "scripts": {