Rename PM owner to created_by

Author: johannaengland

docs/reference/img/ER_model.png

@@ -24,24 +24,24 @@ def cancel_pms(modeladmin, request, queryset):
 class PlannedMaintenanceTaskAdmin(admin.ModelAdmin):
     # Planned maintenance list
     list_display = (
-        "owner",
+        "created_by",
         "created",
         "start_time",
         "end_time",
         "description",
     )
     search_fields = (
         "description",
-        "owner__first_name",
-        "owner__last_name",
-        "owner__username",
+        "created_by__first_name",
+        "created_by__last_name",
+        "created_by__username",
         "filters__name",
         "filters__user__first_name",
         "filters__user__last_name",
         "filters__user__username",
     )
     list_filter = [
-        ("owner", admin.RelatedOnlyFieldListFilter),
+        ("created_by", admin.RelatedOnlyFieldListFilter),
         list_filter_factory(
             "future",
             lambda qs, yes_filter: qs.future() if yes_filter else qs.filter(start_time__lte=timezone.now()),
@@ -58,8 +58,8 @@ class PlannedMaintenanceTaskAdmin(admin.ModelAdmin):
         ),
     ]
 
-    list_select_related = ("owner",)
-    raw_id_fields = ("owner",)
+    list_select_related = ("created_by",)
+    raw_id_fields = ("created_by",)
     ordering = ("start_time",)
 
     actions = [cancel_pms]

src/argus/plannedmaintenance/admin.py

@@ -0,0 +1,22 @@
+from zoneinfo import ZoneInfo
+
+import factory
+
+from argus.auth.factories import PersonUserFactory
+from argus.plannedmaintenance import models
+from argus.util.datetime_utils import LOCAL_INFINITY
+
+
+__all__ = [
+    "PlannedMaintenanceFactory",
+]
+
+
+class PlannedMaintenanceFactory(factory.django.DjangoModelFactory):
+    class Meta:
+        model = models.PlannedMaintenanceTask
+
+    created_by = factory.SubFactory(PersonUserFactory)
+    start_time = factory.Faker("date_time_between", start_date="-2d", end_date="-1d", tzinfo=ZoneInfo("UTC"))
+    end_time = LOCAL_INFINITY
+    description = factory.Faker("sentence")

src/argus/plannedmaintenance/factories.py

@@ -1,4 +1,4 @@
-# Generated by Django 5.2.3 on 2025-11-25 11:46
+# Generated by Django 5.2.3 on 2025-11-27 08:52
 
 import datetime
 import django.db.models.deletion
@@ -55,7 +55,7 @@ class Migration(migrations.Migration):
                     ),
                 ),
                 (
-                    "owner",
+                    "created_by",
                     models.ForeignKey(
                         on_delete=django.db.models.deletion.CASCADE,
                         related_name="planned_maintenance_tasks",

src/argus/plannedmaintenance/migrations/0001_initial.py

@@ -45,7 +45,7 @@ class Meta:
             ),
         ]
 
-    owner = models.ForeignKey(to=User, on_delete=models.CASCADE, related_name="planned_maintenance_tasks")
+    created_by = models.ForeignKey(to=User, on_delete=models.CASCADE, related_name="planned_maintenance_tasks")
     created = models.DateTimeField(default=timezone.now)
     start_time = models.DateTimeField(default=timezone.now)
     end_time = models.DateTimeField(default=LOCAL_INFINITY)
@@ -78,4 +78,4 @@ def cancel(self, end_time: Optional[datetime] = None):
         self.save()
 
     def __str__(self):
-        return f"Planned maintenance from {self.start_time} to {self.end_time if self.end_time != LOCAL_INFINITY else INFINITY_REPR} owned by {self.owner} - {self.description}"
+        return f"Planned maintenance from {self.start_time} to {self.end_time if self.end_time != LOCAL_INFINITY else INFINITY_REPR} created by {self.created_by} - {self.description}"

src/argus/plannedmaintenance/models.py

@@ -70,6 +70,7 @@ def teardown(self):
 
     def test_given_open_pm_task_modifiable_is_true(self):
         open_pm_task = PlannedMaintenanceTask(created_by=self.user)
+
         self.assertTrue(open_pm_task.modifiable)
 
     def test_given_recently_ended_pm_task_modifiable_is_true(self):
@@ -87,7 +88,7 @@ def test_given_long_ago_ended_pm_task_modifiable_is_false(self):
             start_time=timezone.now() - MODIFICATION_WINDOW_PM - timedelta(hours=2),
             end_time=timezone.now() - MODIFICATION_WINDOW_PM - timedelta(hours=1),
         )
-        self.assertFalse(self.past_pm.modifiable)
+        self.assertFalse(open_pm_task.modifiable)
 
     def test_given_active_pm_current_is_true(self):
         pm = PlannedMaintenanceFactory(start_time=timezone.now() - timedelta(minutes=5))