-
Notifications
You must be signed in to change notification settings - Fork 15
Fail codecov check on coverage drop more than 1% #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fail codecov check on coverage drop more than 1% #1528
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1528 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 130 130
Lines 5911 5911
=======================================
Hits 4679 4679
Misses 1232 1232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lunkwill42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that a 10% decrease in coverage in a single PR is pretty steep. Current CLOC of Argus seems to be slighty above 9400. 10% of that would be 940 lines...
I agree, 1% then? |
86e327f to
64151e0
Compare
|



Scope and purpose
Reference: https://docs.codecov.com/docs/commit-status#threshold
Currently the codecov check will succeed even on a 90% drop in coverage. I think 10% drop was the intended target, but we can of course discuss about the specific number.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.
Added a changelog fragment for towncrierAdded/amended tests for new/changed codeAdded/changed documentation, including updates to the user manual if feature flow or UI is considerably changedused the
https://codecov.io/validateAPI endpoint to validate the config file