Specify key requirements in validate_key_value error #511
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 73 73
Lines 3584 3584
=======================================
Hits 2855 2855
Misses 729 729 ☔ View full report in Codecov by Sentry. |
stveit
changed the title
johannaengland
left a comment
johannaengland
left a comment
There was a problem hiding this comment.
When posting to /api/v1/incidents/ with the following tags [{"tag": "HELLO=world"}] I get the error "Enter a valid key consisting of lowercase letters, numbers and underscores." which stems from line 20 in the same file.
But it is still good to also include the key requirements in this error message
Co-authored-by: Johanna England <[email protected]>
stveit
force-pushed
the
specify-key-requirement
branch
from
81c443c to
50d3748
Compare
|
johannaengland
left a comment
johannaengland
left a comment
There was a problem hiding this comment.
Only needs a changelog file
4 participants
Updates the error message to include requirements for the key. Previously, if you tried to add a tag with invalid Key, it was not clear this could be the issue in the error message.