Merge branch '5.15.x'

Author: lunkwill42

CHANGELOG.md

@@ -11,6 +11,18 @@ This project uses [*towncrier*](https://towncrier.readthedocs.io/) and the chang
 
 <!-- towncrier release notes start -->
 
+## [5.15.1] - 2025-11-17
+
+### Fixed
+
+- Fixed crash reports being sent by unauthenticated clients accessing the API
+  ([#3650](https://github.com/Uninett/nav/issues/3650))
+- Fixed non-working port overviews for devices that contain modules with
+  slashes in their name. A broken interfaces API endpoint caused both
+  *ipdevinfo* and *interface browser* port lists to malfunction.
+  ([#3652](https://github.com/Uninett/nav/issues/3652))
+
+
 ## [5.15.0] - 2025-10-30
 
 ### Security

python/nav/django/settings.py

@@ -245,7 +245,7 @@
 REST_FRAMEWORK = {
     'DEFAULT_FILTER_BACKENDS': ('django_filters.rest_framework.DjangoFilterBackend',),
     'DEFAULT_PAGINATION_CLASS': 'nav.web.api.v1.NavPageNumberPagination',
-    'UNAUTHENTICATED_USER': 'nav.django.utils.default_account',
+    'UNAUTHENTICATED_USER': 'nav.web.auth.utils.default_account',
 }
 
 # Classes that implement a search engine for the web navbar

python/nav/web/api/v1/urls.py

@@ -56,7 +56,7 @@
 
 
 urlpatterns = [
-    path('', views.api_root),
+    path('', views.api_root, name="root"),
     path('token/', views.get_or_create_token, name="token"),
     path('version/', views.get_nav_version, name="version"),
     path('prefix/routed/', views.RoutedPrefixList.as_view(), name="prefix-routed-list"),

python/nav/web/ipdevinfo/urls.py

@@ -48,7 +48,7 @@
     ),
     # Module details
     path(
-        '<str:netbox_sysname>/module=<str:module_name>/',
+        '<str:netbox_sysname>/module=<path:module_name>/',
         views.module_details,
         name='ipdevinfo-module-details',
     ),

tests/integration/api_test.py

@@ -69,6 +69,17 @@ def test_allowed_endpoints(db, api_client, token, serializer_models, name, url):
         assert response.status_code == 200
 
 
+def test_unauthenticated_user_can_access_api_root(db):
+    from rest_framework.test import APIClient
+
+    client = APIClient()
+
+    url = reverse("api:1:root")
+
+    response = client.get(url)
+    assert response.status_code == 200
+
+
 @pytest.mark.parametrize("endpoint", ['account', 'location', 'room', 'vlan'])
 def test_delete(db, api_client, token, endpoint):
     create_token_endpoint(token, endpoint)

tests/integration/web/ipdevinfo_test.py

@@ -91,6 +91,18 @@ def test_bad_name_should_not_crash_ipdevinfo(client, badname):
     assert badname in smart_str(response.content)
 
 
+def test_when_module_name_contains_slash_then_module_details_should_not_crash(
+    client, netbox
+):
+    module = netbox.modules.first()
+    module.name = "1/A"
+    module.save()
+    url = reverse('ipdevinfo-module-details', args=(netbox.sysname, "1/A"))
+    response = client.get(url)
+    assert netbox.sysname in smart_str(response.content)
+    assert module.name in smart_str(response.content)
+
+
 class TestRefreshIpdevinfoJob:
     def test_given_netbox_and_job_posts_refresh_event(db, client, netbox):
         now = datetime.now()