User profile end-of-life #928
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspolakovs
commented
Aug 23, 2020
LordAro
reviewed
Aug 23, 2020
| $domain = Config::$email_domain; | ||
| $long_name = Config::$long_name; | ||
| $short_name = Config::$short_name; | ||
| mail( |
Member
There was a problem hiding this comment.
There must be an existing send mail function somewhere
Member
Author
There was a problem hiding this comment.
The comment immediately above:
We use mail() manually to avoid hacking with the innards of MyRadioEmail (as it'd refuse to send due to receive_email being false)
You do have a valid point though, and it may be better to refactor MRE to allow "send immediately, even if they've opted out".
cs-endo
reviewed
Sep 7, 2020
Contributor
cs-endo
left a comment
cs-endo
left a comment
There was a problem hiding this comment.
Looks good - can't say I can confirm the php entirely (so I won't approve) but I don't see any obvious issues throughout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the RFC for context: https://docs.google.com/document/d/1KluuaMP7OnDT_s8e0ED_C0KDD6fgXae3riJi1BZYza0/edit#