Skip to content

Commit d39da4e

Browse files
committed
UsersTest: use default page and limit for list items tests
1 parent 78d4943 commit d39da4e

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

src/test/java/com/uwetrottmann/trakt5/services/UsersTest.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -213,28 +213,24 @@ public void test_updateList() throws IOException {
213213

214214
@Test
215215
public void test_listItems() throws IOException {
216-
int page = 1;
217-
int limit = 1000;
218216
Response<List<ListEntry>> response = executeCallWithoutReadingBody(
219217
getTrakt().users().listItems(UserSlug.ME,
220-
String.valueOf(TEST_LIST_WITH_ITEMS_TRAKT_ID), page, limit, null));
218+
String.valueOf(TEST_LIST_WITH_ITEMS_TRAKT_ID), PAGE_ONE, LIST_AND_COLLECTION_MAX_LIMIT, null));
221219

222-
assertPaginationHeaders(response, page, limit);
220+
assertListPaginationHeaders(response);
223221
assertListEntries(response.body());
224222
}
225223

226224
@Test
227225
public void test_listItems_sortOrder() throws IOException {
228-
int page = 1;
229-
int limit = 1000;
230226
String sortBy = "added";
231227
String sortHow = "desc";
232228
Response<List<ListEntry>> response = executeCallWithoutReadingBody(
233229
getTrakt().users().listItems(UserSlug.ME,
234230
String.valueOf(TEST_LIST_WITH_ITEMS_TRAKT_ID),
235-
sortBy, sortHow, page, limit, null));
231+
sortBy, sortHow, PAGE_ONE, LIST_AND_COLLECTION_MAX_LIMIT, null));
236232

237-
assertPaginationHeaders(response, page, limit);
233+
assertListPaginationHeaders(response);
238234
// The list items are ordered as requested, but no X-Applied headers are returned, instead the X-Sort headers
239235
// update with nonsensical values.
240236
// assertSortOrderHeaders(response, sortBy, sortHow);
@@ -255,17 +251,15 @@ public void test_listItems_type() throws IOException {
255251

256252
@Test
257253
public void test_listItems_typeAndsortOrder() throws IOException {
258-
int page = 1;
259-
int limit = 1000;
260254
String sortBy = "title";
261255
String sortHow = "desc";
262256
Response<List<ListEntry>> response = executeCallWithoutReadingBody(
263257
getTrakt().users().listItems(UserSlug.ME,
264258
String.valueOf(TEST_LIST_WITH_ITEMS_TRAKT_ID),
265-
"movie,show", sortBy, sortHow, page, limit, null)
259+
"movie,show", sortBy, sortHow, PAGE_ONE, LIST_AND_COLLECTION_MAX_LIMIT, null)
266260
);
267261

268-
assertPaginationHeaders(response, page, limit);
262+
assertListPaginationHeaders(response);
269263
// The list items are ordered as requested, but no X-Applied headers are returned, instead the X-Sort headers
270264
// update to the requested by and how values.
271265
// assertSortOrderHeaders(response, sortBy, sortHow);

0 commit comments

Comments
 (0)