Update Scope and ResourceType completers to get contained strings, move logic for Get-AzureRmResource into ProcessRecord

Author: cormacpayne

src/ResourceManager/Common/Commands.ResourceManager.Common/ArgumentCompleters/ResourceTypeCompleter.cs

@@ -131,7 +131,7 @@ private static ScriptBlock CreateScriptBlock()
         {
             string script = "param($commandName, $parameterName, $wordToComplete, $commandAst, $fakeBoundParameter)\n" +
                 "$locations = [Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters.ResourceTypeCompleterAttribute]::GetResourceTypes()\n" +
-                "$locations | Where-Object { $_ -Like \"$wordToComplete*\" } | ForEach-Object { [System.Management.Automation.CompletionResult]::new($_, $_, 'ParameterValue', $_) }";
+                "$locations | Where-Object { $_ -Like \"*$wordToComplete*\" } | ForEach-Object { [System.Management.Automation.CompletionResult]::new($_, $_, 'ParameterValue', $_) }";
             ScriptBlock scriptBlock = ScriptBlock.Create(script);
             return scriptBlock;
         }

src/ResourceManager/Common/Commands.ResourceManager.Common/ArgumentCompleters/ScopeCompleter.cs

@@ -107,7 +107,7 @@ private static ScriptBlock CreateScriptBlock()
         {
             string script = "param($commandName, $parameterName, $wordToComplete, $commandAst, $fakeBoundParameter)\n" +
                 "$scopes = [Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters.ScopeCompleterAttribute]::GetScopes()\n" +
-                "$scopes | Where-Object { $_ -Like \"$wordToComplete*\" } | ForEach-Object { [System.Management.Automation.CompletionResult]::new($_, $_, 'ParameterValue', $_) }";
+                "$scopes | Where-Object { $_ -Like \"*$wordToComplete*\" } | ForEach-Object { [System.Management.Automation.CompletionResult]::new($_, $_, 'ParameterValue', $_) }";
             ScriptBlock scriptBlock = ScriptBlock.Create(script);
             return scriptBlock;
         }

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Resource/GetAzureResourceCmdlet.cs

@@ -51,7 +51,7 @@ public sealed class GetAzureResourceCmdlet : ResourceManagerCmdletBase
         /// Gets or sets the resource name parameter.
         /// </summary>
         [Alias("Id")]
-        [Parameter(ParameterSetName = ByResourceIdParameterSet, Mandatory = true)]
+        [Parameter(ParameterSetName = ByResourceIdParameterSet, Mandatory = true, ValueFromPipelineByPropertyName = true)]
         [ValidateNotNullOrEmpty]
         public string ResourceId { get; set; }
 
@@ -121,14 +121,6 @@ public sealed class GetAzureResourceCmdlet : ResourceManagerCmdletBase
         protected override void OnProcessRecord()
         {
             base.OnProcessRecord();
-        }
-
-        /// <summary>
-        /// Finishes the pipeline execution and runs the cmdlet.
-        /// </summary>
-        protected override void OnEndProcessing()
-        {
-            base.OnEndProcessing();
             this.DefaultApiVersion = string.IsNullOrWhiteSpace(this.ApiVersion) ? Constants.ResourcesApiVersion : this.ApiVersion;
             var resourceId = string.Empty;
             if (ShouldConstructResourceId(out resourceId))
@@ -151,6 +143,14 @@ protected override void OnEndProcessing()
             }
         }
 
+        /// <summary>
+        /// Finishes the pipeline execution and runs the cmdlet.
+        /// </summary>
+        protected override void OnEndProcessing()
+        {
+            base.OnEndProcessing();
+        }
+
         private void RunSimpleCmdlet()
         {
             if (this.IsParameterBound(c => c.Tag))