chore: fix linting error

Fix or override issues found by linters.

Author: nijel

pyproject.toml

@@ -429,8 +429,6 @@ max_allowed_size_uncompressed = '300M'
 [tool.pylint.main]
 disable = [
   "abstract-method",  # TODO
-  "arguments-differ",  # TODO
-  "arguments-renamed",  # TODO
   "attribute-defined-outside-init",  # TODO
   "broad-exception-caught",  # TODO
   "c-extension-no-member",
@@ -443,7 +441,7 @@ disable = [
   "import-outside-toplevel",
   "invalid-name",  # TODO
   "invalid-overridden-method",  # TODO
-  "invalid-str-returned",
+  "invalid-str-returned",  # Most of Django __str__ fails this
   "keyword-arg-before-vararg",  # TODO
   "line-too-long",
   "missing-class-docstring",
@@ -456,8 +454,6 @@ disable = [
   "not-callable",
   "protected-access",  # TODO
   "raising-bad-type",
-  "redefined-builtin",  # TODO
-  "redefined-outer-name",  # TODO
   "too-few-public-methods",
   "too-many-ancestors",
   "too-many-arguments",
@@ -471,7 +467,6 @@ disable = [
   "too-many-public-methods",
   "too-many-return-statements",
   "too-many-statements",
-  "unspecified-encoding",  # TODO
   "unsubscriptable-object",
   "unsupported-assignment-operation",  # TODO
   "unsupported-binary-operation",
@@ -577,7 +572,6 @@ ignore = [
   "PLC0415",  # TODO: `import` should be at the top-level of a file
   "PLR2004",  # TODO: Magic value used in comparison, consider replacing 201 with a constant variable
   "PLR6301",  # TODO: Method could be a function, class method, or static method
-  "PLW1514",  # TODO: `open` in text mode without explicit `encoding` argument
   "PLW2901",  # TODO: overwriting variables inside loop
   "PT",  # CONFIG: Not using pytest
   "PTH",  # TODO: Not using pathlib

scripts/extract-release-notes.py

@@ -16,7 +16,7 @@
 
 tag = f'<section id="weblate-{version}">.+?<h1>(.+?)<a(.+?)</a></h1>(.+?)</section>'
 
-data = Path("docs/_build/html/changes.html").read_text()
+data = Path("docs/_build/html/changes.html").read_text(encoding="utf-8")
 
 for match in re.findall(tag, data, re.MULTILINE | re.DOTALL):
     print(match[0])

scripts/generate-license-data.py

@@ -49,17 +49,18 @@ def escape_string(string: str) -> str:
     "Beerware",
 }
 
-with open("scripts/spdx-license-list/json/licenses.json") as handle:
+with open("scripts/spdx-license-list/json/licenses.json", encoding="utf-8") as handle:
     data = json.load(handle)
 
-with open("weblate/utils/licensedata.py", "w") as output:
+with open("weblate/utils/licensedata.py", "w", encoding="utf-8") as output:
     output.write(HEADER)
     output.write("LICENSES = (\n")
     for item in sorted(data["licenses"], key=lambda x: x["name"].lower()):
         if item["isDeprecatedLicenseId"]:
             continue
         with open(
-            f"scripts/spdx-license-list/json/details/{item['licenseId']}.json"
+            f"scripts/spdx-license-list/json/details/{item['licenseId']}.json",
+            encoding="utf-8",
         ) as handle:
             details = json.load(handle)
         libre = (

scripts/generate-specialchars.py

@@ -377,7 +377,7 @@
 
 
 # Parse CSV passed on the command line
-with open(sys.argv[1]) as handle:
+with open(sys.argv[1], encoding="utf-8") as handle:
     for (
         pos,
         _change,

scripts/reproducible-sbom.py

@@ -27,7 +27,7 @@ def generate_uuid(payload: str) -> UUID:
     sys.exit(1)
 
 filename = sys.argv[1]
-with open(filename) as handle:
+with open(filename, encoding="utf-8") as handle:
     data = json.load(handle)
 
 # Remove varying fields
@@ -41,6 +41,6 @@ def generate_uuid(payload: str) -> UUID:
 # Update serial number
 data["serialNumber"] = f"urn:uuid:{reproducible_uuid}"
 
-with open(filename, "w") as handle:
+with open(filename, "w", encoding="utf-8") as handle:
     json.dump(data, handle, indent=2)
     handle.write("\n")

scripts/set-version.py

@@ -22,15 +22,15 @@
 
 
 def replace_file(name: str, search: str, replace: str) -> None:
-    content = Path(name).read_text()
+    content = Path(name).read_text(encoding="utf-8")
 
     content = re.sub(search, replace, content, flags=re.MULTILINE)
-    Path(name).write_text(content)
+    Path(name).write_text(content, encoding="utf-8")
 
 
 def prepend_file(name: str, content: str) -> None:
-    content += Path(name).read_text()
-    Path(name).write_text(content)
+    content += Path(name).read_text(encoding="utf-8")
+    Path(name).write_text(content, encoding="utf-8")
 
 
 yaml = YAML()

weblate/accounts/avatar.py

@@ -18,7 +18,7 @@
 from django.utils.translation import gettext, pgettext
 
 from weblate.utils.errors import report_error
-from weblate.utils.requests import request
+from weblate.utils.requests import http_request
 
 if TYPE_CHECKING:
     from weblate.auth.models import User
@@ -77,7 +77,7 @@ def get_avatar_image(user: User, size: int) -> bytes:
 def download_avatar_image(email: str, size: int) -> bytes:
     """Download avatar image from remote server."""
     url = avatar_for_email(email, size)
-    response = request("get", url, timeout=1.0)
+    response = http_request("get", url, timeout=1.0)
     return response.content
 
 

weblate/accounts/forms.py

@@ -707,6 +707,7 @@ class SetPasswordForm(DjangoSetPasswordForm):
     )
 
     @transaction.atomic
+    # pylint: disable-next=arguments-renamed
     def save(self, request: AuthenticatedHttpRequest, delete_session=False) -> None:
         AuditLog.objects.create(
             self.user,

weblate/accounts/management/commands/importuserdata.py

@@ -62,6 +62,7 @@ def handle_compat(self, data) -> None:
             "watched": data["subscriptions"],
         }
 
+    # pylint: disable-next=arguments-differ
     def handle(self, **options) -> None:
         """
         Create default set of groups.

weblate/accounts/pipeline.py

@@ -33,7 +33,7 @@
 from weblate.trans.defines import FULLNAME_LENGTH
 from weblate.utils import messages
 from weblate.utils.ratelimit import reset_rate_limit
-from weblate.utils.requests import request
+from weblate.utils.requests import http_request
 from weblate.utils.validators import (
     CRUD_RE,
     USERNAME_MATCHER,
@@ -55,7 +55,7 @@ class EmailAlreadyAssociated(AuthAlreadyAssociated):
 
 def get_github_emails(access_token):
     """Get real e-mail from GitHub."""
-    response = request(
+    response = http_request(
         "get",
         "https://api.github.com/user/emails",
         headers={"Authorization": f"token {access_token}"},