feat: use clone to fetch remote repositories

This allows VCS to configure local based on the remote like object
format for upcoming Git transition to SHA256.

Fixes #16994

Author: nijel

weblate/trans/models/component.py

@@ -3027,6 +3027,10 @@ def sync_git_repo(
             return
         if skip_push is None:
             skip_push = validate
+        if not self.is_repo_local and not self.repository.is_valid():
+            with self.repository.lock:
+                self.repository.clone_from(self.repo)
+
         self.configure_repo(validate)
         if not skip_commit and self.id:
             self.commit_pending("sync", None, skip_push=skip_push)

weblate/vcs/base.py

@@ -94,7 +94,6 @@ def __init__(
         branch: str | None = None,
         component: Component | None = None,
         local: bool = False,
-        skip_init: bool = False,
     ) -> None:
         self.path: str = path
         if branch is None:
@@ -115,12 +114,9 @@ def __init__(
         )
         self._config_updated = False
         self.local = local
+        # Create ssh wrapper for possible use
         if not local:
-            # Create ssh wrapper for possible use
             SSH_WRAPPER.create()
-            if not skip_init and not self.is_valid():
-                with self.lock:
-                    self.create_blank_repository(self.path)
 
     @classmethod
     def get_remote_branch(cls, repo: str) -> str:  # noqa: ARG003
@@ -347,14 +343,18 @@ def _clone(cls, source: str, target: str, branch: str) -> None:
         """Clone repository."""
         raise NotImplementedError
 
+    def clone_from(self, source: str) -> None:
+        """Clone repository into current one."""
+        self._clone(source, self.path, self.branch)
+
     @classmethod
     def clone(
         cls, source: str, target: str, branch: str, component: Component | None = None
     ) -> Self:
         """Clone repository and return object for cloned repository."""
-        repo = cls(target, branch=branch, component=component, skip_init=True)
+        repo = cls(target, branch=branch, component=component)
         with repo.lock:
-            cls._clone(source, target, branch)
+            repo.clone_from(source)
         return repo
 
     def update_remote(self) -> None:

weblate/vcs/git.py

@@ -696,11 +696,8 @@ def __init__(
         branch: str | None = None,
         component: Component | None = None,
         local: bool = False,
-        skip_init: bool = False,
     ) -> None:
-        super().__init__(
-            path, branch=branch, component=component, local=local, skip_init=skip_init
-        )
+        super().__init__(path, branch=branch, component=component, local=local)
         self._fetch_revision: str | None = None
 
     @classmethod
@@ -2166,11 +2163,8 @@ def __init__(
         branch: str | None = None,
         component: Component | None = None,
         local: bool = False,
-        skip_init: bool = False,
     ) -> None:
-        super().__init__(
-            path, branch=branch, component=component, local=local, skip_init=skip_init
-        )
+        super().__init__(path, branch=branch, component=component, local=local)
         self.bb_fork: dict = {}
 
     def get_headers(self, credentials: GitCredentials) -> dict[str, str]:

weblate/vcs/tests/test_vcs.py

@@ -169,7 +169,9 @@ def test_weblate_repo_init(self) -> None:
             repo = self._class(
                 tempdir, branch=self._remote_branch, component=self.get_fake_component()
             )
+            self.assertFalse(repo.is_valid())
             with repo.lock:
+                repo.clone_from(self.get_remote_repo_url())
                 repo.configure_remote(
                     self.get_remote_repo_url(),
                     "",