Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 26, 2025

This PR contains the following updates:

Package Change Age Confidence
translate-toolkit >=3.16.1,<3.17 -> >=3.16.1,<3.18 age confidence

Release Notes

translate/translate (translate-toolkit)

v3.17.0

Compare Source

The major changes in this release are:

  • Added support for TOML, XLIFF 2.0, Nextcloud JSON, and RESJSON formats.
  • Improvements in PO, CSV, Properties, YAML, HTML, PHP, DTD, RC, TMX and Markdown formats.
  • Dropped Python 3.9 compatibility.

Read the full Release notes for more details.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies PR: Third-party library dependencies. label Nov 26, 2025
@renovate renovate bot enabled auto-merge (squash) November 26, 2025 15:05
@renovate renovate bot force-pushed the renovate/translate-toolkit-3.x branch from 0b7f331 to 62b3c4e Compare November 26, 2025 15:47
@nijel
Copy link
Member

nijel commented Nov 26, 2025

Needs more changes, #17064 handles this.

@nijel nijel closed this Nov 26, 2025
auto-merge was automatically disabled November 26, 2025 16:07

Pull request was closed

@renovate
Copy link
Contributor Author

renovate bot commented Nov 26, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (>=3.16.1,<3.18). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/translate-toolkit-3.x branch November 26, 2025 16:09
@codecov
Copy link

codecov bot commented Nov 26, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
5164 2 5162 663
View the top 1 failed test(s) by shortest run time
weblate.formats.tests.test_formats.LaravelPhpFormatTest::test_find
Stack Traces | 0.23s run time
self = <weblate.formats.ttkit.LaravelPhpFormat object at 0x12a08d220>
context = "return[]->'apples'", source = "return[]->'apples'"

    def _find_unit_monolingual(
        self, context: str, source: str
    ) -> tuple[TranslationUnit, bool]:
        # We search by ID when using template
        id_hash = self._calculate_string_hash(context, source)
        try:
>           result = self._unit_index[id_hash]
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
E           KeyError: -3884641218248778629

weblate/formats/base.py:462: KeyError

The above exception was the direct cause of the following exception:

self = <weblate.formats.tests.test_formats.LaravelPhpFormatTest testMethod=test_find>

    def test_find(self) -> None:
        storage = self.parse_file(self.FILE)
>       unit, add = storage.find_unit(self.FIND_CONTEXT, self.FIND)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.../formats/tests/test_formats.py:290: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
weblate/formats/base.py:500: in find_unit
    return self._find_unit_monolingual(context, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <weblate.formats.ttkit.LaravelPhpFormat object at 0x12a08d220>
context = "return[]->'apples'", source = "return[]->'apples'"

    def _find_unit_monolingual(
        self, context: str, source: str
    ) -> tuple[TranslationUnit, bool]:
        # We search by ID when using template
        id_hash = self._calculate_string_hash(context, source)
        try:
            result = self._unit_index[id_hash]
        except KeyError as error:
>           raise UnitNotFoundError(context, source) from error
E           weblate.formats.base.UnitNotFoundError: Unit not found: return[]->'apples', return[]->'apples'

weblate/formats/base.py:464: UnitNotFoundError
View the full list of 1 ❄️ flaky test(s)
weblate.formats.tests.test_formats.LaravelPhpFormatTest::test_new_unit

Flake rate in main: 50.00% (Passed 1 times, Failed 1 times)

Stack Traces | 0.08s run time
self = <weblate.formats.tests.test_formats.LaravelPhpFormatTest testMethod=test_new_unit>

    def test_new_unit(self) -> None:
        if not self.format_class.can_add_unit:
            self.skipTest("Not supported")
        # Read test content
        testdata = Path(self.FILE).read_bytes()
    
        # Create test file
        testfile = os.path.join(self.tempdir, f"test.{self.EXT}")
    
        # Write test data to file
        Path(testfile).write_bytes(testdata)
    
        # Parse test file
        storage = self.parse_file(testfile, template=testfile)
        if self.MONOLINGUAL:
            # Add to template for monolingual (it is the same file, just different object)
            storage = storage.template_store
    
        # Add new unit
        storage.new_unit(self.NEW_UNIT_KEY, "Source string")
        storage.save()
    
        # Read new content
        newdata = Path(testfile).read_bytes()
    
        # Check if content matches
        if isinstance(self.NEW_UNIT_MATCH, tuple):
            for match in self.NEW_UNIT_MATCH:
                self.assertIn(match, newdata)
        else:
>           self.assertIn(self.NEW_UNIT_MATCH, newdata)
E           AssertionError: b"\n$LANG['key'] = 'Source string';\n" not found in b"<?php\nreturn [\n    'welcome' => 'Welcome to our application',\n    'apples' => 'There is one apple|There are many apples',\n    '$LANG[\\'key\\']' => 'Source string',\n];\n"

.../formats/tests/test_formats.py:358: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PR: Third-party library dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants