Skip to content

DRAFT: Ximinez/lending vault payments #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: ximinez/lending-XLS-66-2
Choose a base branch
from
Draft

DRAFT: Ximinez/lending vault payments #5629

wants to merge 19 commits into from

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Jul 28, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez ximinez changed the base branch from develop to ximinez/lending-XLS-66 July 28, 2025 23:56
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 3 times, most recently from 6a788f5 to e0844fb Compare July 30, 2025 00:37
@ximinez ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jul 30, 2025
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 4 times, most recently from 55dcec3 to 8845a3c Compare August 6, 2025 01:32
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from 1bf68f7 to 1628756 Compare August 6, 2025 15:47
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 3 times, most recently from 79c4196 to 99ed1ac Compare August 9, 2025 05:00
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 2 times, most recently from be33808 to 03e8fde Compare August 18, 2025 22:16
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from 7f478d9 to e62efa2 Compare August 19, 2025 00:35
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 7 times, most recently from 167dadc to cfd5320 Compare August 25, 2025 23:53
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 4 times, most recently from 852cffa to aac549b Compare August 29, 2025 22:09
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 3 times, most recently from fe40960 to 1502d8b Compare September 3, 2025 23:21
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch 8 times, most recently from d6a985d to 872d44d Compare November 10, 2025 21:02
@ximinez
Make VaultWithdraw with destination use the payment engine
bfac68e 
- Calls the same functions as LoanBrokerCoverWithdraw
- See b34f59e, 10b7352, 6b42363, and e6e6360
- Many unit test failures. I'm not sure how accurate they are
@ximinez
WIP: Make requireAuth recursive if the sender is a vault
078afb5
@ximinez ximinez force-pushed the ximinez/lending-vault-payments branch from 872d44d to 078afb5 Compare November 11, 2025 00:54
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from 156186d to 590f69c Compare November 23, 2025 02:24
@ximinez
Merge remote-tracking branch 'XRPLF/ximinez/lending-XLS-66' into ximi…
992a62a 
…nez/lending-vault-payments

* XRPLF/ximinez/lending-XLS-66: (47 commits)
  Review feedback from @gregtatcam: typo
  Review feedback from @Tapanito, @gregtatcam, and @shawnxie999
  Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp
  Fix formatting
  Add deep freeze check to LoanBrokerDelete (6053)
  Fix build error with LoanBroker invariant
  Address a couple of feedback items from @Tapanito and @shawnxie999:
  Review feedback from @shawnxie999: removeEmptyHolding
  Review feedback from @shawnxie999: broker owner count
  Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp
  Update src/xrpld/app/tx/detail/LoanBrokerCoverDeposit.cpp
  Update src/xrpld/app/tx/detail/LoanBrokerSet.cpp
  Add a LoanBroker invariant to compare CoverAvailable to balance
  refactor: Retire RequireFullyCanonicalSig amendment (6035)
  refactor: Retire DeletableAccounts amendment (6056)
  refactor: Retire CryptoConditionsSuite amendment (6036)
  Review feedback from @gregtatcam: variable name
  Review feedback from @gregtatcam: readability
  From discussion with @gregtatcam: Revert "Payment"
  Review feedback from @gregtatcam: compute vs. calculate
  ...
@ximinez
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-vault-paym…
f9027bb 
…ents
@ximinez
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-vault-paym…
c6ff988 
…ents
@ximinez
Merge remote-tracking branch 'XRPLF/ximinez/lending-XLS-66' into ximi…
c7d73fb 
…nez/lending-vault-payments

* XRPLF/ximinez/lending-XLS-66:
  Review feedback from @shawnxie999: MPT Clawback
  Move the ValidPseudoAccounts class back to its original location
  Fix formatting again
  refactor: Retire Flow and FlowSortStrands amendments (6054)
  Add additional documentation to Lending Protocol (6037)
@ximinez
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-vault-paym…
f665463 
…ents
@ximinez
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-vault-paym…
d5d6b0c 
…ents
@ximinez
Merge branch 'develop' into ximinez/lending-XLS-66
19c72b3
@ximinez
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-vault-paym…
d9a44db 
…ents
@ximinez ximinez changed the base branch from ximinez/lending-XLS-66 to ximinez/lending-XLS-66-2 December 1, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bronek Bronek Bronek left review comments

Assignees

No one assigned

Labels

Blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ximinez @Bronek