fix: check error before deferring rows.Close

l2dy · l2dy · commit beff54b0ea92 · 2025-08-22T05:52:33.000Z
diff --git a/tests/e2e/function/prepare_stmt.go b/tests/e2e/function/prepare_stmt.go
@@ -119,13 +119,13 @@ var _ = ginkgo.Describe("prepare stmt test", func() {
 
 func checkPrepareExecRes(db *sql.Stmt, params []interface{}, values [][]string) error {
 	rows, err := db.Query(params[0].(int), params[1].(string))
-	defer rows.Close()
 	if err != nil {
 		if err == sql.ErrNoRows && len(values) == 0 {
 			return nil
 		}
 		return fmt.Errorf("db Exec Error %v", err)
 	}
+	defer rows.Close()
 
 	res, err := util.GetDataFromRows(rows)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -119,13 +119,13 @@ var _ = ginkgo.Describe("prepare stmt test", func() {`
`119`	`119`
`120`	`120`	`func checkPrepareExecRes(db *sql.Stmt, params []interface{}, values [][]string) error {`
`121`	`121`	`rows, err := db.Query(params[0].(int), params[1].(string))`
`122`		`- defer rows.Close()`
`123`	`122`	`if err != nil {`
`124`	`123`	`if err == sql.ErrNoRows && len(values) == 0 {`
`125`	`124`	`return nil`
`126`	`125`	`}`
`127`	`126`	`return fmt.Errorf("db Exec Error %v", err)`
`128`	`127`	`}`
	`128`	`+ defer rows.Close()`
`129`	`129`
`130`	`130`	`res, err := util.GetDataFromRows(rows)`
`131`	`131`	`if err != nil {`