Skip to content

Commit e7bd381

Browse files
committed
[BOOK-508] fix: reflect reviews
1 parent 6ff5a47 commit e7bd381

5 files changed

Lines changed: 2 additions & 60 deletions

File tree

src/Projects/BKData/Sources/DTO/Response/DetailRecordResponseDTO.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ extension DetailRecordResponseDTO {
3939
}
4040
}
4141

42-
// api-v2
4342
public struct DetailRecordV2ResponseDTO: Decodable {
4443
public let id: String
4544
public let userBookId: String

src/Projects/BKDomain/Sources/Entity/Emotion.swift

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -7,51 +7,3 @@ public enum Emotion: String, CaseIterable, Decodable {
77
case insight = "깨달음"
88
case other = "기타"
99
}
10-
11-
public enum SubEmotion: String, CaseIterable {
12-
// 따뜻함
13-
case comforted = "위로받은"
14-
case cozy = "포근한"
15-
case tender = "다정한"
16-
case grateful = "고마운"
17-
case relieved = "마음이 놓이는"
18-
case peaceful = "편안한"
19-
20-
// 즐거움
21-
case excited = "설레는"
22-
case satisfied = "뿌듯한"
23-
case cheerful = "유쾌한"
24-
case joyful = "기쁜"
25-
case thrilling = "흥미진진한"
26-
27-
// 슬픔
28-
case hollow = "허무한"
29-
case lonely = "외로운"
30-
case regretful = "아쉬운"
31-
case stunned = "먹먹한"
32-
case bittersweet = "애틋한"
33-
case pitiful = "안타까운"
34-
case nostalgic = "그리운"
35-
36-
// 깨달음
37-
case amazed = "감탄한"
38-
case insightful = "통찰력을 얻은"
39-
case inspired = "영감을 받은"
40-
case deepened = "생각이 깊어진"
41-
case understood = "새롭게 이해한"
42-
43-
public static func subEmotions(for emotion: Emotion) -> [SubEmotion] {
44-
switch emotion {
45-
case .warmth:
46-
return [.comforted, .cozy, .tender, .grateful, .relieved, .peaceful]
47-
case .joy:
48-
return [.excited, .satisfied, .cheerful, .joyful, .thrilling]
49-
case .sad:
50-
return [.hollow, .lonely, .regretful, .stunned, .bittersweet, .pitiful, .nostalgic]
51-
case .insight:
52-
return [.amazed, .insightful, .inspired, .deepened, .understood]
53-
case .other:
54-
return []
55-
}
56-
}
57-
}

src/Projects/BKPresentation/Sources/MainFlow/BookDetail/View/BookDetailViewCell.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,7 @@ final class BookDetailViewCell: UICollectionViewCell {
8484
noteLabel.setText(text: displayedNote)
8585
emotionTagLabel.setText(text: "#\(emotion.displayName)")
8686
creationLabel.setText(text: item.createdAt.toKoreanDotDateString())
87-
if let page = item.page {
88-
pageLabel.setText(text: "\(page)p")
89-
} else {
90-
pageLabel.setText(text: "-p")
91-
}
87+
pageLabel.setText(text: item.page.toPageString)
9288
}
9389

9490
func applyMoreButtonGesture(

src/Projects/BKPresentation/Sources/MainFlow/Note/View/EmotionRegistrationView.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,6 @@ final class EmotionRegistrationView: BaseView {
371371
rowView.addGestureRecognizer(tapGesture)
372372
rowView.tag = emotion.hashValue
373373

374-
// Set up chip removal callback
375374
rowView.onDetailEmotionRemoved = { [weak self] detailEmotion in
376375
self?.removeDetailEmotion(detailEmotion)
377376
}

src/Projects/BKPresentation/Sources/MainFlow/NoteCompletion/View/CollectedSentenceView.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,7 @@ final class CollectedSentenceView: BaseView {
8080
) {
8181
let displayedText = "\"\(sentence)\""
8282
collectedSentenceLabel.setText(text: displayedText)
83-
if let page {
84-
pageLabel.setText(text: "\(page)p")
85-
} else {
86-
pageLabel.setText(text: "-p")
87-
}
83+
pageLabel.setText(text: page.toPageString)
8884
}
8985
}
9086

0 commit comments

Comments
 (0)