Remove function.expression

Author: fisker

acorn-loose/src/expression.js

@@ -540,7 +540,6 @@ lp.initFunction = function(node) {
   node.params = []
   if (this.options.ecmaVersion >= 6) {
     node.generator = false
-    node.expression = false
   }
   if (this.options.ecmaVersion >= 8)
     node.async = false

acorn/src/expression.js

@@ -903,7 +903,7 @@ pp.parsePropertyName = function(prop) {
 
 pp.initFunction = function(node) {
   node.id = null
-  if (this.options.ecmaVersion >= 6) node.generator = node.expression = false
+  if (this.options.ecmaVersion >= 6) node.generator = false
   if (this.options.ecmaVersion >= 8) node.async = false
 }
 
@@ -964,7 +964,6 @@ pp.parseFunctionBody = function(node, isArrowFunction, isMethod, forInit) {
 
   if (isExpression) {
     node.body = this.parseMaybeAssign(forInit)
-    node.expression = true
     this.checkParams(node, false)
   } else {
     let nonSimple = this.options.ecmaVersion >= 7 && !this.isSimpleParamList(node.params)
@@ -988,7 +987,6 @@ pp.parseFunctionBody = function(node, isArrowFunction, isMethod, forInit) {
     // Ensure the function name isn't a forbidden identifier in strict mode, e.g. 'eval'
     if (this.strict && node.id) this.checkLValSimple(node.id, BIND_OUTSIDE)
     node.body = this.parseBlock(false, undefined, useStrict && !oldStrict)
-    node.expression = false
     this.adaptDirectivePrologue(node.body.body)
     this.labels = oldLabels
   }

test/tests-async-iteration.js

@@ -23,7 +23,6 @@ test("async function f() { for await (x of xs); }", {
         "name": "f"
       },
       "generator": false,
-      "expression": false,
       "async": true,
       "params": [],
       "body": {
@@ -76,7 +75,6 @@ test("async function f() { for await (var x of xs); }", {
         "name": "f"
       },
       "generator": false,
-      "expression": false,
       "async": true,
       "params": [],
       "body": {
@@ -143,7 +141,6 @@ test("async function f() { for await (let x of xs); }", {
         "name": "f"
       },
       "generator": false,
-      "expression": false,
       "async": true,
       "params": [],
       "body": {
@@ -210,7 +207,6 @@ test("async function f() { for\nawait (x of xs); }", {
         "name": "f"
       },
       "generator": false,
-      "expression": false,
       "async": true,
       "params": [],
       "body": {
@@ -273,7 +269,6 @@ test("f = async function() { for await (x of xs); }", {
           "end": 45,
           "id": null,
           "generator": false,
-          "expression": false,
           "async": true,
           "params": [],
           "body": {
@@ -338,7 +333,6 @@ test("f = async() => { for await (x of xs); }", {
           "end": 39,
           "id": null,
           "generator": false,
-          "expression": false,
           "async": true,
           "params": [],
           "body": {
@@ -421,7 +415,6 @@ test("obj = { async f() { for await (x of xs); } }", {
                 "end": 42,
                 "id": null,
                 "generator": false,
-                "expression": false,
                 "async": true,
                 "params": [],
                 "body": {
@@ -504,7 +497,6 @@ test("class A { async f() { for await (x of xs); } }", {
               "end": 44,
               "id": null,
               "generator": false,
-              "expression": false,
               "async": true,
               "params": [],
               "body": {
@@ -676,7 +668,6 @@ test("async function* f() { await a; yield b; }", {
         "name": "f"
       },
       "generator": true,
-      "expression": false,
       "async": true,
       "params": [],
       "body": {
@@ -759,7 +750,6 @@ test("f = async function*() { await a; yield b; }", {
           "end": 43,
           "id": null,
           "generator": true,
-          "expression": false,
           "async": true,
           "params": [],
           "body": {
@@ -852,7 +842,6 @@ test("obj = { async* f() { await a; yield b; } }", {
                 "end": 40,
                 "id": null,
                 "generator": true,
-                "expression": false,
                 "async": true,
                 "params": [],
                 "body": {
@@ -945,7 +934,6 @@ test("class A { async* f() { await a; yield b; } }", {
               "end": 42,
               "id": null,
               "generator": true,
-              "expression": false,
               "async": true,
               "params": [],
               "body": {
@@ -1036,7 +1024,6 @@ test("class A { static async* f() { await a; yield b; } }", {
               "end": 49,
               "id": null,
               "generator": true,
-              "expression": false,
               "async": true,
               "params": [],
               "body": {
@@ -1255,7 +1242,6 @@ test("var gen = { async *method() {} }", {
                   "end": 30,
                   "id": null,
                   "generator": true,
-                  "expression": false,
                   "async": true,
                   "params": [],
                   "body": {
@@ -1291,7 +1277,6 @@ test("export default async function*() {}", {
         "end": 35,
         "id": null,
         "generator": true,
-        "expression": false,
         "async": true,
         "params": [],
         "body": {