Use the maximum access validity time provided by GoCardless (#551)

matt-fidd · web-flow · commit 45d53ff771b6 · 2025-01-15T23:34:00.000Z
* use validForMax supplied by GoCardless

* remove overrides in bank handlers

* note

* update types
diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js
@@ -13,7 +13,6 @@ import DanskebankDabno22 from './banks/danskebank_dabno22.js';
 import EasybankBawaatww from './banks/easybank_bawaatww.js';
 import EntercardSwednokk from './banks/entercard_swednokk.js';
 import FortuneoFtnofrp1xxx from './banks/fortuneo_ftnofrp1xxx.js';
-import HanseaticHstbdehh from './banks/hanseatic_hstbdehh.js';
 import HypeHyeeit22 from './banks/hype_hyeeit22.js';
 import IngIngbrobu from './banks/ing_ingbrobu.js';
 import IngIngddeff from './banks/ing_ingddeff.js';
@@ -53,7 +52,6 @@ export const banks = [
   EasybankBawaatww,
   EntercardSwednokk,
   FortuneoFtnofrp1xxx,
-  HanseaticHstbdehh,
   HypeHyeeit22,
   IngIngbrobu,
   IngIngddeff,
diff --git a/src/app-gocardless/banks/abanca_caglesmm.js b/src/app-gocardless/banks/abanca_caglesmm.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL'],
 
-  accessValidForDays: 180,
-
   // Abanca transactions doesn't get the creditorName/debtorName properly
   normalizeTransaction(transaction, _booked) {
     transaction.creditorName = transaction.remittanceInformationStructured;
diff --git a/src/app-gocardless/banks/abnamro_abnanl2a.js b/src/app-gocardless/banks/abnamro_abnanl2a.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['ABNAMRO_ABNANL2A'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     // There is no remittanceInformationUnstructured, so we'll make it
     transaction.remittanceInformationUnstructured =
diff --git a/src/app-gocardless/banks/american_express_aesudef1.js b/src/app-gocardless/banks/american_express_aesudef1.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['AMERICAN_EXPRESS_AESUDEF1'],
 
-  accessValidForDays: 180,
-
   normalizeAccount(account) {
     return {
       ...Fallback.normalizeAccount(account),
diff --git a/src/app-gocardless/banks/bancsabadell_bsabesbbb.js b/src/app-gocardless/banks/bancsabadell_bsabesbbb.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['BANCSABADELL_BSABESBB'],
 
-  accessValidForDays: 180,
-
   // Sabadell transactions don't get the creditorName/debtorName properly
   normalizeTransaction(transaction, _booked) {
     const amount = transaction.transactionAmount.amount;
diff --git a/src/app-gocardless/banks/bank.interface.ts b/src/app-gocardless/banks/bank.interface.ts
@@ -7,8 +7,6 @@ import { Transaction, Balance } from '../gocardless-node.types.js';
 export interface IBank {
   institutionIds: string[];
 
-  accessValidForDays: number;
-
   /**
    * Returns normalized object with required data for the frontend
    */
diff --git a/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js b/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js
@@ -6,8 +6,6 @@ export default {
 
   institutionIds: ['BANK_OF_IRELAND_B365_BOFIIE2D'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, booked) {
     transaction.remittanceInformationUnstructured = fixupPayee(
       transaction.remittanceInformationUnstructured,
diff --git a/src/app-gocardless/banks/bankinter_bkbkesmm.js b/src/app-gocardless/banks/bankinter_bkbkesmm.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['BANKINTER_BKBKESMM'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     transaction.remittanceInformationUnstructured =
       transaction.remittanceInformationUnstructured
diff --git a/src/app-gocardless/banks/belfius_gkccbebb.js b/src/app-gocardless/banks/belfius_gkccbebb.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['BELFIUS_GKCCBEBB'],
 
-  accessValidForDays: 180,
-
   // The problem is that we have transaction with duplicated transaction ids.
   // This is not expected and the nordigen api has a work-around for some backs
   // They will set an internalTransactionId which is unique
diff --git a/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js b/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['BERLINER_SPARKASSE_BELADEBEXXX'],
 
-  accessValidForDays: 180,
-
   /**
    * Following the GoCardless documentation[0] we should prefer `bookingDate`
    * here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/bnp_be_gebabebb.js b/src/app-gocardless/banks/bnp_be_gebabebb.js
@@ -12,8 +12,6 @@ export default {
     'BNP_BE_GEBABEBB',
   ],
 
-  accessValidForDays: 180,
-
   /** BNP_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
    *  There does not seem to be a specification of this field, but the following information is contained in its subfields:
    *  - for pending transactions: the 'atmPosName'
diff --git a/src/app-gocardless/banks/cbc_cregbebb.js b/src/app-gocardless/banks/cbc_cregbebb.js
@@ -7,8 +7,6 @@ export default {
 
   institutionIds: ['CBC_CREGBEBB'],
 
-  accessValidForDays: 180,
-
   /**
    * For negative amounts, the only payee information we have is returned in
    * remittanceInformationUnstructured.
diff --git a/src/app-gocardless/banks/danskebank_dabno22.js b/src/app-gocardless/banks/danskebank_dabno22.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['DANSKEBANK_DABANO22'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     /**
      * Danske Bank appends the EndToEndID: NOTPROVIDED to
diff --git a/src/app-gocardless/banks/easybank_bawaatww.js b/src/app-gocardless/banks/easybank_bawaatww.js
@@ -10,8 +10,6 @@ export default {
 
   institutionIds: ['EASYBANK_BAWAATWW'],
 
-  accessValidForDays: 179,
-
   // If date is same, sort by transactionId
   sortTransactions: (transactions = []) =>
     transactions.sort((a, b) => {
diff --git a/src/app-gocardless/banks/entercard_swednokk.js b/src/app-gocardless/banks/entercard_swednokk.js
@@ -11,8 +11,6 @@ export default {
 
   institutionIds: ['ENTERCARD_SWEDNOKK'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     // GoCardless's Entercard integration returns forex transactions with the
     // foreign amount in `transactionAmount`, but at least the amount actually
diff --git a/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js b/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['FORTUNEO_FTNOFRP1XXX'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     const date =
       transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/hanseatic_hstbdehh.js b/src/app-gocardless/banks/hanseatic_hstbdehh.js
diff --git a/src/app-gocardless/banks/hype_hyeeit22.js b/src/app-gocardless/banks/hype_hyeeit22.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['HYPE_HYEEIT22'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     /** Online card payments - identified by "crd" transaction code
      *  always start with PAGAMENTO PRESSO + <payee name>
diff --git a/src/app-gocardless/banks/ing_ingbrobu.js b/src/app-gocardless/banks/ing_ingbrobu.js
@@ -6,8 +6,6 @@ export default {
 
   institutionIds: ['ING_INGBROBU'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, booked) {
     //Merchant transactions all have the same transactionId of 'NOTPROVIDED'.
     //For booked transactions, this can be set to the internalTransactionId
diff --git a/src/app-gocardless/banks/ing_ingddeff.js b/src/app-gocardless/banks/ing_ingddeff.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['ING_INGDDEFF'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     const remittanceInformationMatch = /remittanceinformation:(.*)$/.exec(
       transaction.remittanceInformationUnstructured,
diff --git a/src/app-gocardless/banks/ing_pl_ingbplpw.js b/src/app-gocardless/banks/ing_pl_ingbplpw.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['ING_PL_INGBPLPW'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     return {
       ...transaction,
diff --git a/src/app-gocardless/banks/integration-bank.js b/src/app-gocardless/banks/integration-bank.js
@@ -20,13 +20,6 @@ const SORTED_BALANCE_TYPE_LIST = [
 export default {
   institutionIds: ['IntegrationBank'],
 
-  // EEA need to allow at least 180 days now but this doesn't apply to UK
-  // banks, and it's possible that there are EEA banks which still don't follow
-  // the new requirements. See:
-  // - https://nordigen.zendesk.com/hc/en-gb/articles/13239212055581-EEA-180-day-access
-  // - https://nordigen.zendesk.com/hc/en-gb/articles/6760902653085-Extended-history-and-continuous-access-edge-cases
-  accessValidForDays: 90,
-
   normalizeAccount(account) {
     console.debug(
       'Available account properties for new institution integration',
diff --git a/src/app-gocardless/banks/isybank_itbbitmm.js b/src/app-gocardless/banks/isybank_itbbitmm.js
@@ -6,8 +6,6 @@ export default {
 
   institutionIds: ['ISYBANK_ITBBITMM'],
 
-  accessValidForDays: 180,
-
   // It has been reported that valueDate is more accurate than booking date
   // when it is provided
   normalizeTransaction(transaction, booked) {
diff --git a/src/app-gocardless/banks/kbc_kredbebb.js b/src/app-gocardless/banks/kbc_kredbebb.js
@@ -7,8 +7,6 @@ export default {
 
   institutionIds: ['KBC_KREDBEBB'],
 
-  accessValidForDays: 180,
-
   /**
    * For negative amounts, the only payee information we have is returned in
    * remittanceInformationUnstructured.
diff --git a/src/app-gocardless/banks/mbank_retail_brexplpw.js b/src/app-gocardless/banks/mbank_retail_brexplpw.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['MBANK_RETAIL_BREXPLPW'],
 
-  accessValidForDays: 179,
-
   normalizeTransaction(transaction, _booked) {
     return {
       ...transaction,
diff --git a/src/app-gocardless/banks/nbg_ethngraaxxx.js b/src/app-gocardless/banks/nbg_ethngraaxxx.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['NBG_ETHNGRAAXXX'],
 
-  accessValidForDays: 180,
-
   /**
    * Fixes for the pending transactions:
    * - Corrects amount to negative (nbg erroneously omits the minus sign in pending transactions)
diff --git a/src/app-gocardless/banks/norwegian_xx_norwnok1.js b/src/app-gocardless/banks/norwegian_xx_norwnok1.js
@@ -16,8 +16,6 @@ export default {
     'NORWEGIAN_FI_NORWNOK1',
   ],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, booked) {
     if (booked) {
       return {
diff --git a/src/app-gocardless/banks/revolut_revolt21.js b/src/app-gocardless/banks/revolut_revolt21.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['REVOLUT_REVOLT21'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     if (
       transaction.remittanceInformationUnstructuredArray[0].startsWith(
diff --git a/src/app-gocardless/banks/sandboxfinance_sfin0000.js b/src/app-gocardless/banks/sandboxfinance_sfin0000.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['SANDBOXFINANCE_SFIN0000'],
 
-  accessValidForDays: 180,
-
   /**
    * Following the GoCardless documentation[0] we should prefer `bookingDate`
    * here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/seb_kort_bank_ab.js b/src/app-gocardless/banks/seb_kort_bank_ab.js
@@ -13,8 +13,6 @@ export default {
     'SEB_CARD_ESSESESS',
   ],
 
-  accessValidForDays: 180,
-
   /**
    * Sign of transaction amount needs to be flipped for SEB credit cards
    */
diff --git a/src/app-gocardless/banks/seb_privat.js b/src/app-gocardless/banks/seb_privat.js
@@ -10,8 +10,6 @@ export default {
 
   institutionIds: ['SEB_ESSESESS_PRIVATE'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     const date =
       transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/sparnord_spnodk22.js b/src/app-gocardless/banks/sparnord_spnodk22.js
@@ -12,8 +12,6 @@ export default {
     'ANDELSKASSEN_FALLESKASSEN_FAELDKK1',
   ],
 
-  accessValidForDays: 180,
-
   /**
    * Banks on the BEC backend only give information regarding the transaction in additionalInformation
    */
diff --git a/src/app-gocardless/banks/spk_karlsruhe_karsde66.js b/src/app-gocardless/banks/spk_karlsruhe_karsde66.js
@@ -9,8 +9,6 @@ export default {
 
   institutionIds: ['SPK_KARLSRUHE_KARSDE66XXX'],
 
-  accessValidForDays: 180,
-
   /**
    * Following the GoCardless documentation[0] we should prefer `bookingDate`
    * here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js b/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js
@@ -10,8 +10,6 @@ export default {
 
   institutionIds: ['SPK_MARBURG_BIEDENKOPF_HELADEF1MAR'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     const date =
       transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js b/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['SPK_WORMS_ALZEY_RIED_MALADE51WOR'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     const date = transaction.bookingDate || transaction.valueDate;
     if (!date) {
diff --git a/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js b/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js
@@ -6,8 +6,6 @@ export default {
 
   institutionIds: ['SSK_DUSSELDORF_DUSSDEDDXXX'],
 
-  accessValidForDays: 180,
-
   normalizeTransaction(transaction, _booked) {
     // Prioritize unstructured information, falling back to structured formats
     let remittanceInformationUnstructured =
diff --git a/src/app-gocardless/banks/swedbank_habalv22.js b/src/app-gocardless/banks/swedbank_habalv22.js
@@ -8,8 +8,6 @@ export default {
 
   institutionIds: ['SWEDBANK_HABALV22'],
 
-  accessValidForDays: 180,
-
   /**
    * The actual transaction date for card transactions is only available in the remittanceInformationUnstructured field when the transaction is booked.
    */
diff --git a/src/app-gocardless/banks/tests/ing_ingddeff.spec.js b/src/app-gocardless/banks/tests/ing_ingddeff.spec.js
@@ -20,6 +20,7 @@ describe('IngIngddeff', () => {
         name: 'ING',
         bic: 'INGDDEFFXXX',
         transaction_total_days: '390',
+        max_access_valid_for_days: '90',
         countries: ['DE'],
         logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/ing.png',
         supported_payments: {
@@ -59,6 +60,7 @@ describe('IngIngddeff', () => {
             'single-payment': ['SCT'],
           },
           transaction_total_days: '390',
+          max_access_valid_for_days: '90',
         },
         mask: '5030',
         name: 'Girokonto (XXX 5030) EUR',
diff --git a/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js b/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js
diff --git a/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js b/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js
diff --git a/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js b/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js
diff --git a/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js b/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js
diff --git a/src/app-gocardless/gocardless-node.types.ts b/src/app-gocardless/gocardless-node.types.ts
diff --git a/src/app-gocardless/services/gocardless-service.js b/src/app-gocardless/services/gocardless-service.js
diff --git a/src/app-gocardless/services/tests/fixtures.js b/src/app-gocardless/services/tests/fixtures.js
diff --git a/upcoming-release-notes/551.md b/upcoming-release-notes/551.md
