Skip to content

Commit 17a4825

Browse files
committed
fix(shared-clients): consume runtime enums from data-service-types
1 parent a44d623 commit 17a4825

6 files changed

Lines changed: 39 additions & 107 deletions

File tree

package-lock.json

Lines changed: 29 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/spacecat-shared-scrape-client/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636
},
3737
"dependencies": {
3838
"@adobe/helix-universal": "5.4.0",
39-
"@adobe/spacecat-shared-utils": "1.81.1"
39+
"@adobe/spacecat-shared-utils": "1.81.1",
40+
"@mysticat/data-service-types": "github:adobe/mysticat-data-service#types-ts-v1.11.1"
4041
},
4142
"devDependencies": {
4243
"chai": "6.2.1",

packages/spacecat-shared-scrape-client/src/clients/scrape-client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,13 @@
1313
import {
1414
hasText, isIsoDate, isNonEmptyArray, isObject, isValidUrl, isValidUUID,
1515
} from '@adobe/spacecat-shared-utils';
16+
import { MYSTICAT_ENUMS_BY_TYPE } from '@mysticat/data-service-types';
1617
import { ScrapeJobDto } from './scrapeJobDto.js';
1718
import ScrapeJobSupervisor from './scrape-job-supervisor.js';
1819
import { ScrapeUrlDto } from './scrapeUrlDto.js';
1920

2021
const SCRAPE_PROCESSING_TYPE_DEFAULT = 'default';
21-
const SCRAPE_URL_STATUS_COMPLETE = 'COMPLETE';
22+
const SCRAPE_URL_STATUS_COMPLETE = MYSTICAT_ENUMS_BY_TYPE.SCRAPE_URL_STATUS.COMPLETE;
2223

2324
export default class ScrapeClient {
2425
config = null;

packages/spacecat-shared-scrape-client/src/clients/scrape-job-supervisor.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
*/
1212

1313
import { isValidUrl, isValidUUID, composeBaseURL } from '@adobe/spacecat-shared-utils';
14+
import { MYSTICAT_ENUMS_BY_TYPE } from '@mysticat/data-service-types';
1415

15-
const SCRAPE_JOB_STATUS_RUNNING = 'RUNNING';
16+
const SCRAPE_JOB_STATUS_RUNNING = MYSTICAT_ENUMS_BY_TYPE.SCRAPE_JOB_STATUS.RUNNING;
1617

1718
/**
1819
* Scrape Supervisor provides functionality to start and manage scrape jobs.

packages/spacecat-shared-tier-client/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
"access": "public"
3636
},
3737
"dependencies": {
38-
"@adobe/spacecat-shared-utils": "1.81.1"
38+
"@adobe/spacecat-shared-utils": "1.81.1",
39+
"@mysticat/data-service-types": "github:adobe/mysticat-data-service#types-ts-v1.11.1"
3940
},
4041
"devDependencies": {
4142
"c8": "10.1.3",

0 commit comments

Comments
 (0)