fix mypy issues

Author: biswapanda

tests/serve/lora_utils.py

@@ -158,6 +158,7 @@ def create_bucket(self) -> None:
                 f"s3://{self.config.bucket}",
             ],
             capture_output=True,
+            text=True,
             env=env,
         )
 
@@ -174,6 +175,7 @@ def create_bucket(self) -> None:
                     f"s3://{self.config.bucket}",
                 ],
                 capture_output=True,
+                text=True,
                 env=env,
             )
             if result.returncode != 0:
@@ -237,6 +239,7 @@ def upload_lora(self, local_path: str) -> None:
                 "*.git*",
             ],
             capture_output=True,
+            text=True,
             env=env,
         )
 

tests/serve/test_vllm.py

@@ -6,6 +6,7 @@
 import os
 import random
 from dataclasses import dataclass, field
+from typing import Optional
 
 import pytest
 
@@ -603,8 +604,8 @@ def __init__(
         s3_uri: str,
         system_port: int = 8081,
         repeat_count: int = 1,
-        expected_response: list = None,
-        expected_log: list = None,
+        expected_response: Optional[list] = None,
+        expected_log: Optional[list] = None,
         timeout: int = 60,
     ):
         super().__init__(
@@ -680,8 +681,8 @@ def lora_chat_payload(
     s3_uri: str,
     system_port: int = 8081,
     repeat_count: int = 2,
-    expected_response: list = None,
-    expected_log: list = None,
+    expected_response: Optional[list] = None,
+    expected_log: Optional[list] = None,
     max_tokens: int = 100,
     temperature: float = 0.0,
 ) -> LoraTestChatPayload:

tests/utils/payloads.py

@@ -20,7 +20,7 @@
 from dataclasses import dataclass
 from typing import Any, Callable, Dict, List, Optional
 
-from dynamo import prometheus_names
+from dynamo import prometheus_names  # type: ignore[attr-defined]
 
 logger = logging.getLogger(__name__)