skip-service-restart

Author: tmonty12

tests/fault_tolerance/deploy/conftest.py

@@ -36,7 +36,7 @@ def pytest_addoption(parser):
         "By default, these tests are excluded.",
     )
     parser.addoption(
-        "--skip-restart-services",
+        "--skip-service-restart",
         action="store_true",
         default=False,
         help="Skip restarting NATS and etcd services before deployment. "
@@ -119,6 +119,6 @@ def client_type(request):
 
 
 @pytest.fixture
-def skip_restart_services(request):
+def skip_service_restart(request):
     """Get skip restart services flag from command line."""
-    return request.config.getoption("--skip-restart-services")
+    return request.config.getoption("--skip-service-restart")

tests/fault_tolerance/deploy/test_deployment.py

@@ -363,7 +363,7 @@ async def test_fault_scenario(
     request,
     image: str,
     namespace: str,
-    skip_restart_services: bool,
+    skip_service_restart: bool,
 ):
     """
     Test dynamo serve deployments with injected failures
@@ -408,7 +408,7 @@ async def test_fault_scenario(
         namespace=namespace,
         log_dir=request.node.log_dir,
         deployment_spec=scenario.deployment,
-        skip_restart_services=skip_restart_services,
+        skip_service_restart=skip_service_restart,
     ) as deployment:
         with _clients(
             logger,

tests/utils/managed_deployment.py

@@ -492,7 +492,7 @@ class ManagedDeployment:
     # TODO: this should be determined by the deployment_spec
     # the service containing component_type: Frontend determines what is actually the frontend service
     frontend_service_name: str = "Frontend"
-    skip_restart_services: bool = False
+    skip_service_restart: bool = False
 
     _custom_api: Optional[client.CustomObjectsApi] = None
     _core_api: Optional[Any] = None
@@ -992,7 +992,7 @@ async def __aenter__(self):
 
             # Run delete deployment and service restarts in parallel
             tasks = [self._delete_deployment()]
-            if not self.skip_restart_services:
+            if not self.skip_service_restart:
                 tasks.extend([self._restart_etcd(), self._restart_nats()])
             await asyncio.gather(*tasks)