Skip to content

Commit 52fb615

Browse files
committed
Updated the kvbm wheel check in Dockerfile
Signed-off-by: pvijayakrish <[email protected]>
1 parent 2191c02 commit 52fb615

File tree

3 files changed

+26
-29
lines changed

3 files changed

+26
-29
lines changed

container/Dockerfile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -410,16 +410,15 @@ RUN uv pip install \
410410
/opt/dynamo/wheelhouse/ai_dynamo*any.whl \
411411
/opt/dynamo/wheelhouse/nixl/nixl*.whl && \
412412
if [ "$ENABLE_KVBM" = "true" ]; then \
413-
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1) && \
414-
if [ -n "$KVBM_WHEEL" ]; then \
415-
uv pip install "$KVBM_WHEEL"; \
416-
else \
413+
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1); \
414+
if [ -z "$KVBM_WHEEL" ]; then \
417415
echo "ERROR: ENABLE_KVBM is true but no KVBM wheel found in wheelhouse" >&2; \
418416
exit 1; \
419417
fi; \
420-
fi \
421-
&& cd /workspace/benchmarks \
422-
&& UV_GIT_LFS=1 uv pip install --no-cache .
418+
uv pip install "$KVBM_WHEEL"; \
419+
fi && \
420+
cd /workspace/benchmarks && \
421+
UV_GIT_LFS=1 uv pip install --no-cache .
423422

424423
# Setup launch banner in common directory accessible to all users
425424
RUN --mount=type=bind,source=./container/launch_message/runtime.txt,target=/opt/dynamo/launch_message.txt \

container/Dockerfile.trtllm

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -340,20 +340,19 @@ RUN uv pip install \
340340
--no-cache \
341341
/opt/dynamo/wheelhouse/ai_dynamo_runtime*.whl \
342342
/opt/dynamo/wheelhouse/ai_dynamo*any.whl \
343-
/opt/dynamo/wheelhouse/nixl/nixl*.whl \
344-
&& if [ "${ENABLE_KVBM}" = "true" ]; then \
345-
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1) && \
346-
if [ -n "$KVBM_WHEEL" ]; then \
347-
uv pip install --no-cache "$KVBM_WHEEL"; \
348-
else \
343+
/opt/dynamo/wheelhouse/nixl/nixl*.whl && \
344+
if [ "${ENABLE_KVBM}" = "true" ]; then \
345+
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1); \
346+
if [ -z "$KVBM_WHEEL" ]; then \
349347
echo "ERROR: ENABLE_KVBM is true but no KVBM wheel found in wheelhouse" >&2; \
350348
exit 1; \
351349
fi; \
352-
fi \
353-
&& cd /opt/dynamo/benchmarks \
354-
&& UV_GIT_LFS=1 uv pip install --no-cache . \
355-
&& cd - \
356-
&& rm -rf /opt/dynamo/benchmarks
350+
uv pip install --no-cache "$KVBM_WHEEL"; \
351+
fi && \
352+
cd /opt/dynamo/benchmarks && \
353+
UV_GIT_LFS=1 uv pip install --no-cache . && \
354+
cd - && \
355+
rm -rf /opt/dynamo/benchmarks
357356

358357
# Install common and test dependencies
359358
RUN --mount=type=bind,source=./container/deps/requirements.txt,target=/tmp/requirements.txt \

container/Dockerfile.vllm

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -271,20 +271,19 @@ COPY --chown=dynamo: --from=dynamo_base /opt/dynamo/wheelhouse/ /opt/dynamo/whee
271271
RUN uv pip install \
272272
/opt/dynamo/wheelhouse/ai_dynamo_runtime*.whl \
273273
/opt/dynamo/wheelhouse/ai_dynamo*any.whl \
274-
/opt/dynamo/wheelhouse/nixl/nixl*.whl \
275-
&& if [ "${ENABLE_KVBM}" = "true" ]; then \
276-
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1) && \
277-
if [ -n "$KVBM_WHEEL" ]; then \
278-
uv pip install "$KVBM_WHEEL"; \
279-
else \
274+
/opt/dynamo/wheelhouse/nixl/nixl*.whl && \
275+
if [ "${ENABLE_KVBM}" = "true" ]; then \
276+
KVBM_WHEEL=$(ls /opt/dynamo/wheelhouse/kvbm*.whl 2>/dev/null | head -1); \
277+
if [ -z "$KVBM_WHEEL" ]; then \
280278
echo "ERROR: ENABLE_KVBM is true but no KVBM wheel found in wheelhouse" >&2; \
281279
exit 1; \
282280
fi; \
283-
fi \
284-
&& cd /opt/dynamo/benchmarks \
285-
&& UV_GIT_LFS=1 uv pip install --no-cache . \
286-
&& cd - \
287-
&& rm -rf /opt/dynamo/benchmarks
281+
uv pip install "$KVBM_WHEEL"; \
282+
fi && \
283+
cd /opt/dynamo/benchmarks && \
284+
UV_GIT_LFS=1 uv pip install --no-cache . && \
285+
cd - && \
286+
rm -rf /opt/dynamo/benchmarks
288287

289288
# Install common and test dependencies
290289
RUN --mount=type=bind,source=./container/deps/requirements.txt,target=/tmp/requirements.txt \

0 commit comments

Comments
 (0)