Skip to content

Commit 88902a6

Browse files
committed
Address review comments, remove redundant docker login
Signed-off-by: pvijayakrish <[email protected]>
1 parent f431b6a commit 88902a6

File tree

3 files changed

+191
-128
lines changed

3 files changed

+191
-128
lines changed

.github/actions/docker-tag-push/action.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,6 @@ runs:
4949
- name: Set up Docker Buildx
5050
uses: docker/setup-buildx-action@v3
5151

52-
- name: Login to Container Registries
53-
uses: ./.github/actions/docker-login
54-
with:
55-
aws_default_region: ${{ inputs.aws_push == 'true' && inputs.aws_default_region || '' }}
56-
aws_account_id: ${{ inputs.aws_push == 'true' && inputs.aws_account_id || '' }}
57-
azure_acr_hostname: ${{ inputs.azure_push == 'true' && inputs.azure_acr_hostname || '' }}
58-
azure_acr_user: ${{ inputs.azure_push == 'true' && inputs.azure_acr_user || '' }}
59-
azure_acr_password: ${{ inputs.azure_push == 'true' && inputs.azure_acr_password || '' }}
60-
6152
- name: ECR Tag and Push
6253
shell: bash
6354
if: ${{ inputs.aws_push == 'true' }}

.github/workflows/container-validation-backends.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,13 @@ jobs:
164164
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
165165
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
166166
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
167+
- name: Login to Container Registries
168+
uses: ./.github/actions/docker-login
169+
with:
170+
azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }}
171+
azure_acr_user: ${{ secrets.AZURE_ACR_USER }}
172+
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}
173+
ngc_ci_access_token: ${{ secrets.NGC_CI_ACCESS_TOKEN }}
167174
- name: Docker Tag and Push
168175
uses: ./.github/actions/docker-tag-push
169176
with:
@@ -222,6 +229,13 @@ jobs:
222229
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
223230
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
224231

232+
- name: Login to Container Registries
233+
uses: ./.github/actions/docker-login
234+
with:
235+
azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }}
236+
azure_acr_user: ${{ secrets.AZURE_ACR_USER }}
237+
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}
238+
ngc_ci_access_token: ${{ secrets.NGC_CI_ACCESS_TOKEN }}
225239
- name: Docker Tag and Push
226240
uses: ./.github/actions/docker-tag-push
227241
with:
@@ -280,6 +294,13 @@ jobs:
280294
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
281295
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
282296

297+
- name: Login to Container Registries
298+
uses: ./.github/actions/docker-login
299+
with:
300+
azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }}
301+
azure_acr_user: ${{ secrets.AZURE_ACR_USER }}
302+
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}
303+
ngc_ci_access_token: ${{ secrets.NGC_CI_ACCESS_TOKEN }}
283304
- name: Docker Tag and Push
284305
uses: ./.github/actions/docker-tag-push
285306
with:

0 commit comments

Comments
 (0)