Skip to content

Commit 8dbd73d

Browse files
pvijayakrishpvijayakrish
committed
Update the job step to error when the corresponding build fails and not quitely skip
Signed-off-by: pvijayakrish <[email protected]>
1 parent 5da0bb0 commit 8dbd73d

File tree

1 file changed

+11
-29
lines changed

1 file changed

+11
-29
lines changed

‎.github/workflows/nightly-ci.yml‎

Lines changed: 11 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -276,13 +276,11 @@ jobs:
276276
277277
echo "Build succeeded. Proceeding with tests."
278278
- name: Login to Container Registries
279-
if: steps.check_build.outputs.skip != 'true'
280279
uses: ./.github/actions/docker-login
281280
with:
282281
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
283282
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
284283
- name: Pull nightly image
285-
if: steps.check_build.outputs.skip != 'true'
286284
shell: bash
287285
env:
288286
ECR_HOSTNAME: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
@@ -291,7 +289,6 @@ jobs:
291289
docker pull ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG}
292290
docker tag ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG} ${IMAGE_TAG}
293291
- name: Run Unit Tests
294-
if: steps.check_build.outputs.skip != 'true'
295292
uses: ./.github/actions/pytest
296293
with:
297294
image_tag: ${{ env.NIGHTLY_IMAGE_PREFIX }}-${{ matrix.framework }}-${{ matrix.arch }}
@@ -344,20 +341,17 @@ jobs:
344341
echo "Build status for '$BUILD_JOB_NAME': $BUILD_STATUS"
345342
346343
if [ "$BUILD_STATUS" != "success" ]; then
347-
echo "Build failed or did not complete successfully. Skipping tests."
348-
echo "skip=true" >> $GITHUB_OUTPUT
349-
exit 0
344+
echo "Build failed or did not complete successfully. Marking tests as failed."
345+
exit 1
350346
fi
351347
352348
echo "Build succeeded. Proceeding with tests."
353349
- name: Login to Container Registries
354-
if: steps.check_build.outputs.skip != 'true'
355350
uses: ./.github/actions/docker-login
356351
with:
357352
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
358353
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
359354
- name: Pull nightly image
360-
if: steps.check_build.outputs.skip != 'true'
361355
shell: bash
362356
env:
363357
ECR_HOSTNAME: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
@@ -366,7 +360,6 @@ jobs:
366360
docker pull ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG}
367361
docker tag ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG} ${IMAGE_TAG}
368362
- name: Run Integration Tests
369-
if: steps.check_build.outputs.skip != 'true'
370363
uses: ./.github/actions/pytest
371364
with:
372365
image_tag: ${{ env.NIGHTLY_IMAGE_PREFIX }}-${{ matrix.framework }}-${{ matrix.arch }}
@@ -425,13 +418,11 @@ jobs:
425418
426419
echo "Build succeeded. Proceeding with tests."
427420
- name: Login to Container Registries
428-
if: steps.check_build.outputs.skip != 'true'
429421
uses: ./.github/actions/docker-login
430422
with:
431423
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
432424
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
433425
- name: Pull nightly image
434-
if: steps.check_build.outputs.skip != 'true'
435426
shell: bash
436427
env:
437428
ECR_HOSTNAME: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
@@ -440,7 +431,6 @@ jobs:
440431
docker pull ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG}
441432
docker tag ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG} ${IMAGE_TAG}
442433
- name: Run E2E Tests (gpu_1)
443-
if: steps.check_build.outputs.skip != 'true'
444434
uses: ./.github/actions/pytest
445435
with:
446436
image_tag: ${{ env.NIGHTLY_IMAGE_PREFIX }}-${{ matrix.framework }}-${{ matrix.arch }}
@@ -493,20 +483,17 @@ jobs:
493483
echo "Build status for '$BUILD_JOB_NAME': $BUILD_STATUS"
494484
495485
if [ "$BUILD_STATUS" != "success" ]; then
496-
echo "Build failed or did not complete successfully. Skipping tests."
497-
echo "skip=true" >> $GITHUB_OUTPUT
498-
exit 0
486+
echo "Build failed or did not complete successfully. Marking tests as failed."
487+
exit 1
499488
fi
500489
501490
echo "Build succeeded. Proceeding with tests."
502491
- name: Login to Container Registries
503-
if: steps.check_build.outputs.skip != 'true'
504492
uses: ./.github/actions/docker-login
505493
with:
506494
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
507495
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
508496
- name: Pull nightly image
509-
if: steps.check_build.outputs.skip != 'true'
510497
shell: bash
511498
env:
512499
ECR_HOSTNAME: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
@@ -515,7 +502,6 @@ jobs:
515502
docker pull ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG}
516503
docker tag ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG} ${IMAGE_TAG}
517504
- name: Run E2E Tests (gpu_2)
518-
if: steps.check_build.outputs.skip != 'true'
519505
uses: ./.github/actions/pytest
520506
with:
521507
image_tag: ${{ env.NIGHTLY_IMAGE_PREFIX }}-${{ matrix.framework }}-${{ matrix.arch }}
@@ -556,22 +542,22 @@ jobs:
556542
# - { framework: sglang, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "nightly and kvbm" }
557543
- { framework: vllm, arch: amd64, component: router, runner: gpu-l40-amd64, timeout: 90, marks: "router and not slow" }
558544
- { framework: vllm, arch: amd64, component: planner, runner: gpu-l40-amd64, timeout: 90, marks: "planner and not slow" }
559-
- { framework: vllm, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) and not slow" }
545+
- { framework: vllm, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) " }
560546
- { framework: vllm, arch: arm64, component: router, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "router and not slow" }
561547
- { framework: vllm, arch: arm64, component: planner, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "planner and not slow" }
562548
- { framework: vllm, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "kvbm and not slow" }
563549
- { framework: trtllm, arch: amd64, component: router, runner: gpu-l40-amd64, timeout: 90, marks: "router and not slow" }
564550
- { framework: trtllm, arch: amd64, component: planner, runner: gpu-l40-amd64, timeout: 90, marks: "planner and not slow" }
565-
- { framework: trtllm, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) and not slow" }
551+
- { framework: trtllm, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) " }
566552
- { framework: trtllm, arch: arm64, component: router, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "router and not slow" }
567553
- { framework: trtllm, arch: arm64, component: planner, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "planner and not slow" }
568-
- { framework: trtllm, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: " (kvbm or kvbm_v2) and not slow" }
554+
- { framework: trtllm, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: " (kvbm or kvbm_v2) " }
569555
- { framework: sglang, arch: amd64, component: router, runner: gpu-l40-amd64, timeout: 90, marks: "router and not slow" }
570556
- { framework: sglang, arch: amd64, component: planner, runner: gpu-l40-amd64, timeout: 90, marks: "planner and not slow" }
571-
- { framework: sglang, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) and not slow" }
557+
- { framework: sglang, arch: amd64, component: kvbm, runner: gpu-l40-amd64, timeout: 90, marks: " (kvbm or kvbm_v2) " }
572558
- { framework: sglang, arch: arm64, component: router, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "router and not slow" }
573559
- { framework: sglang, arch: arm64, component: planner, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: "planner and not slow" }
574-
- { framework: sglang, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: " (kvbm or kvbm_v2) and not slow" }
560+
- { framework: sglang, arch: arm64, component: kvbm, runner: cpu-arm-r8g-4xlarge, timeout: 60, marks: " (kvbm or kvbm_v2) " }
575561

576562
steps:
577563
- uses: actions/checkout@v4
@@ -605,20 +591,17 @@ jobs:
605591
echo "Build status for '$BUILD_JOB_NAME': $BUILD_STATUS"
606592
607593
if [ "$BUILD_STATUS" != "success" ]; then
608-
echo "Build failed or did not complete successfully. Skipping tests."
609-
echo "skip=true" >> $GITHUB_OUTPUT
610-
exit 0
594+
echo "Build failed or did not complete successfully. Marking tests as failed."
595+
exit 1
611596
fi
612597
613598
echo "Build succeeded. Proceeding with tests."
614599
- name: Login to Container Registries
615-
if: steps.check_build.outputs.skip != 'true'
616600
uses: ./.github/actions/docker-login
617601
with:
618602
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
619603
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
620604
- name: Pull nightly image
621-
if: steps.check_build.outputs.skip != 'true'
622605
shell: bash
623606
env:
624607
ECR_HOSTNAME: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
@@ -627,7 +610,6 @@ jobs:
627610
docker pull ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG}
628611
docker tag ${ECR_HOSTNAME}/${{ env.REGISTRY_IMAGE }}:${IMAGE_TAG} ${IMAGE_TAG}
629612
- name: Run Component Tests (${{ matrix.component }})
630-
if: steps.check_build.outputs.skip != 'true'
631613
uses: ./.github/actions/pytest
632614
with:
633615
image_tag: ${{ env.NIGHTLY_IMAGE_PREFIX }}-${{ matrix.framework }}-${{ matrix.arch }}

0 commit comments

Comments
 (0)