Skip to content

Commit ae8f36c

Browse files
Enable deploy tests
Signed-off-by: Dillon Cullinan <[email protected]>
1 parent c9e445a commit ae8f36c

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

.github/workflows/container-validation-backends.yml

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,6 @@ on:
99
- main
1010
- "pull-request/[0-9]+"
1111
- release/*.*.*
12-
workflow_dispatch:
13-
inputs:
14-
run_deploy_operator:
15-
description: 'Run deploy operator and deployment tests'
16-
required: false
17-
type: boolean
18-
default: false
1912

2013
concurrency:
2114
# The group name is a ternary operation. If the ref_name is 'main',
@@ -28,7 +21,6 @@ concurrency:
2821
jobs:
2922
changed-files:
3023
runs-on: ubuntu-latest
31-
environment: ${{ github.event_name == 'workflow_dispatch' && 'protected-deploy' || '' }}
3224
outputs:
3325
has_code_changes: ${{ steps.filter.outputs.has_code_changes }}
3426
steps:
@@ -500,9 +492,7 @@ jobs:
500492
501493
deploy-operator:
502494
runs-on: cpu-amd-m5-2xlarge
503-
# TODO: Uncomment this when we have a way to test the deploy-operator job in CI.
504-
#if: needs.changed-files.outputs.has_code_changes == 'true'
505-
if: github.event.inputs.run_deploy_operator
495+
if: needs.changed-files.outputs.has_code_changes == 'true'
506496
needs: [changed-files, operator, vllm, sglang, trtllm]
507497
env:
508498
DYNAMO_INGRESS_SUFFIX: dev.aire.nvidia.com
@@ -578,9 +568,7 @@ jobs:
578568
579569
deploy-test-vllm:
580570
runs-on: cpu-amd-m5-2xlarge
581-
# TODO: Uncomment this when we have a way to test the deploy-test-vllm job in CI.
582-
#if: needs.changed-files.outputs.has_code_changes == 'true'
583-
if: github.event.inputs.run_deploy_operator
571+
if: needs.changed-files.outputs.has_code_changes == 'true'
584572
needs: [changed-files, deploy-operator, vllm]
585573
permissions:
586574
contents: read
@@ -764,9 +752,7 @@ jobs:
764752
765753
deploy-test-sglang:
766754
runs-on: cpu-amd-m5-2xlarge
767-
# TODO: Uncomment this when we have a way to test the deploy-test-sglang job in CI.
768-
#if: needs.changed-files.outputs.has_code_changes == 'true'
769-
if: github.event.inputs.run_deploy_operator
755+
if: needs.changed-files.outputs.has_code_changes == 'true'
770756
needs: [changed-files, deploy-operator, sglang]
771757
permissions:
772758
contents: read
@@ -787,9 +773,7 @@ jobs:
787773

788774
deploy-test-trtllm:
789775
runs-on: cpu-amd-m5-2xlarge
790-
# TODO: Uncomment this when we have a way to test the deploy-test-trtllm job in CI.
791-
#if: needs.changed-files.outputs.has_code_changes == 'true'
792-
if: github.event.inputs.run_deploy_operator
776+
if: needs.changed-files.outputs.has_code_changes == 'true'
793777
needs: [changed-files, deploy-operator, trtllm]
794778
permissions:
795779
contents: read
@@ -812,9 +796,7 @@ jobs:
812796

813797
cleanup:
814798
runs-on: cpu-amd-m5-2xlarge
815-
# TODO: Uncomment the below if statement when we have a way to test the cleanup job in CI.
816-
# if: always()
817-
if: github.event.inputs.run_deploy_operator
799+
if: always()
818800
needs: [changed-files, deploy-operator, deploy-test-trtllm, deploy-test-sglang, deploy-test-vllm]
819801
steps:
820802
- name: Output Node Name

0 commit comments

Comments
 (0)