Skip to content

Commit b0a5e58

Browse files
committed
Remove redundant --http-port flag from frontend launch commands
dynamo.frontend already reads DYN_HTTP_PORT env var and defaults to 8000, so explicit --http-port=${DYN_HTTP_PORT:-8000} flag is redundant. Add comment to clarify this behavior for maintainability. Signed-off-by: Keiven Chang <[email protected]>
1 parent 4463ec7 commit b0a5e58

26 files changed

+52
-26
lines changed

examples/backends/sglang/launch/agg.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ trap cleanup EXIT INT TERM
1313

1414

1515
# run ingress
16-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
16+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
17+
python3 -m dynamo.frontend &
1718
DYNAMO_PID=$!
1819

1920
# run worker with metrics enabled

examples/backends/sglang/launch/agg_embed.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ trap cleanup EXIT INT TERM
1313

1414

1515
# run ingress
16-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
16+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
17+
python3 -m dynamo.frontend &
1718
DYNAMO_PID=$!
1819

1920
# run worker

examples/backends/sglang/launch/agg_router.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ trap cleanup EXIT INT TERM
1313

1414

1515
# run ingress
16-
python -m dynamo.frontend --router-mode kv --http-port=${DYN_HTTP_PORT:-8000} &
16+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
17+
python -m dynamo.frontend --router-mode kv &
1718
DYNAMO_PID=$!
1819

1920
# run worker

examples/backends/sglang/launch/disagg.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ trap cleanup EXIT INT TERM
1313

1414

1515
# run ingress
16-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
16+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
17+
python3 -m dynamo.frontend &
1718
DYNAMO_PID=$!
1819

1920
# run prefill worker

examples/backends/sglang/launch/disagg_dp_attn.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ trap cleanup EXIT INT TERM
1313

1414

1515
# run ingress
16-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
16+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
17+
python3 -m dynamo.frontend &
1718
DYNAMO_PID=$!
1819

1920
# run prefill worker

examples/backends/sglang/launch/disagg_same_gpu.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ trap cleanup EXIT INT TERM
3737

3838

3939
# run ingress with KV router mode for disaggregated setup
40-
python3 -m dynamo.frontend --router-mode kv --http-port=${DYN_HTTP_PORT:-8000} &
40+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
41+
python3 -m dynamo.frontend --router-mode kv &
4142
DYNAMO_PID=$!
4243

4344
# run prefill worker with metrics on port 8081

examples/backends/sglang/launch/multimodal_agg.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ if [[ -n "$SERVED_MODEL_NAME" ]]; then
6060
fi
6161

6262
# run ingress
63-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
63+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
64+
python3 -m dynamo.frontend &
6465
DYNAMO_PID=$!
6566

6667
# run SGLang multimodal processor

examples/backends/sglang/launch/multimodal_disagg.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ if [[ -n "$SERVED_MODEL_NAME" ]]; then
6060
fi
6161

6262
# run ingress
63-
python3 -m dynamo.frontend --http-port=${DYN_HTTP_PORT:-8000} &
63+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
64+
python3 -m dynamo.frontend &
6465
DYNAMO_PID=$!
6566

6667
# run SGLang multimodal processor

examples/backends/trtllm/launch/agg.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ trap cleanup EXIT INT TERM
2222

2323

2424
# run frontend
25-
python3 -m dynamo.frontend --http-port ${DYN_HTTP_PORT:-8000} &
25+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
26+
python3 -m dynamo.frontend &
2627
DYNAMO_PID=$!
2728

2829
# run worker

examples/backends/trtllm/launch/agg_metrics.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ cleanup() {
1919
trap cleanup EXIT INT TERM
2020

2121
# Run frontend
22-
python3 -m dynamo.frontend --http-port ${DYN_HTTP_PORT:-8000} &
22+
# DYN_HTTP_PORT env var is read by dynamo.frontend (defaults to 8000 if not set)
23+
python3 -m dynamo.frontend &
2324
DYNAMO_PID=$!
2425

2526
# Run worker

0 commit comments

Comments
 (0)