Commit ba316c7
committed
fix(deps): skip sub-dependency ARGs, normalize pinning, and document known discrepancies
**Fixes for extraction accuracy:**
- Skip ARGs for sub-dependencies (e.g., NIXL_UCX_REF is for UCX, not NIXL)
- Fixes false positive showing NIXL v1.19.0 (was actually UCX)
- Exclude PyTorch Triton from PyTorch normalization
- PyTorch Triton (Triton compiler) is a separate package, not PyTorch
- Was causing false positive showing 3 PyTorch versions instead of 2
**Version comparison improvements:**
- Add version normalization to ignore pinning style differences
- '0.6.0' vs '<=0.6.0' are now treated as the same
- '==32.0.1' vs '>=32.0.1,<33.0.0' are now treated as the same
- Only flag discrepancies when actual version numbers differ
**Documentation:**
- Add known_version_discrepancies section to config
- Document intentional PyTorch version difference:
- TensorRT-LLM: 2.8.0 (from NVIDIA container)
- vLLM: 2.7.1+cu128 (ARM64 wheel compatibility)
**Results:**
- Reduced from 6 to 4 real discrepancies
- Eliminated false positives from:
- Sub-dependency ARGs (UCX)
- Pinning style differences (NIXL, Kubernetes)
- Package misidentification (PyTorch Triton)
Signed-off-by: Dan Gil <[email protected]>1 parent 1f8119a commit ba316c7
File tree
2 files changed
+66
-5
lines changed- .github/workflows
2 files changed
+66
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
774 | 774 | | |
775 | 775 | | |
776 | 776 | | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
777 | 786 | | |
778 | 787 | | |
779 | 788 | | |
| |||
1849 | 1858 | | |
1850 | 1859 | | |
1851 | 1860 | | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
1852 | 1867 | | |
1853 | 1868 | | |
1854 | 1869 | | |
| |||
1872 | 1887 | | |
1873 | 1888 | | |
1874 | 1889 | | |
| 1890 | + | |
| 1891 | + | |
| 1892 | + | |
| 1893 | + | |
| 1894 | + | |
| 1895 | + | |
| 1896 | + | |
| 1897 | + | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
| 1910 | + | |
| 1911 | + | |
| 1912 | + | |
| 1913 | + | |
| 1914 | + | |
| 1915 | + | |
| 1916 | + | |
| 1917 | + | |
| 1918 | + | |
1875 | 1919 | | |
1876 | 1920 | | |
1877 | 1921 | | |
| |||
1884 | 1928 | | |
1885 | 1929 | | |
1886 | 1930 | | |
| 1931 | + | |
1887 | 1932 | | |
1888 | 1933 | | |
1889 | 1934 | | |
| |||
1939 | 1984 | | |
1940 | 1985 | | |
1941 | 1986 | | |
| 1987 | + | |
1942 | 1988 | | |
1943 | 1989 | | |
1944 | 1990 | | |
1945 | | - | |
1946 | | - | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
1947 | 1996 | | |
1948 | | - | |
1949 | | - | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
| 2001 | + | |
1950 | 2002 | | |
1951 | 2003 | | |
1952 | 2004 | | |
1953 | | - | |
| 2005 | + | |
| 2006 | + | |
1954 | 2007 | | |
1955 | 2008 | | |
1956 | 2009 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
13 | 21 | | |
14 | 22 | | |
15 | 23 | | |
| |||
0 commit comments