@@ -72,11 +72,10 @@ jobs:
7272 with :
7373 driver : docker
7474 - name : Login to ECR
75- shell : bash
76- env :
77- ECR_HOSTNAME : ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_DEFAULT_REGION }}.amazonaws.com
78- run : |
79- aws ecr get-login-password --region ${{ secrets.AWS_DEFAULT_REGION }} | docker login --username AWS --password-stdin ${ECR_HOSTNAME}
75+ uses : ./.github/actions/docker-login
76+ with :
77+ aws_default_region : ${{ secrets.AWS_DEFAULT_REGION }}
78+ aws_account_id : ${{ secrets.AWS_ACCOUNT_ID }}
8079 - name : Linter
8180 shell : bash
8281 env :
@@ -120,7 +119,7 @@ jobs:
120119 uses : ./.github/actions/docker-tag-push
121120 with :
122121 local_image : dynamo-operator:latest
123- push_tag : ai-dynamo/dynamo:${{ github.sha }}-operator-${{ matrix.platform.arch }}
122+ push_tags : ai-dynamo/dynamo:${{ github.sha }}-operator-${{ matrix.platform.arch }}
124123 aws_push : ' false'
125124 azure_push : ' true'
126125 aws_account_id : ${{ secrets.AWS_ACCOUNT_ID }}
@@ -165,11 +164,18 @@ jobs:
165164 aws_account_id : ${{ secrets.AWS_ACCOUNT_ID }}
166165 aws_access_key_id : ${{ secrets.AWS_ACCESS_KEY_ID }}
167166 aws_secret_access_key : ${{ secrets.AWS_SECRET_ACCESS_KEY }}
167+ - name : Login to Container Registries
168+ uses : ./.github/actions/docker-login
169+ with :
170+ azure_acr_hostname : ${{ secrets.AZURE_ACR_HOSTNAME }}
171+ azure_acr_user : ${{ secrets.AZURE_ACR_USER }}
172+ azure_acr_password : ${{ secrets.AZURE_ACR_PASSWORD }}
173+ ngc_ci_access_token : ${{ secrets.NGC_CI_ACCESS_TOKEN }}
168174 - name : Docker Tag and Push
169175 uses : ./.github/actions/docker-tag-push
170176 with :
171177 local_image : ${{ steps.build-image.outputs.image_tag }}
172- push_tag : ai-dynamo/dynamo:${{ github.sha }}-vllm-${{ matrix.platform.arch }}
178+ push_tags : ai-dynamo/dynamo:${{ github.sha }}-vllm-${{ matrix.platform.arch }}
173179 # OPS-1145: Switch aws_push to true
174180 aws_push : ' false'
175181 azure_push : ' true'
@@ -223,11 +229,18 @@ jobs:
223229 aws_access_key_id : ${{ secrets.AWS_ACCESS_KEY_ID }}
224230 aws_secret_access_key : ${{ secrets.AWS_SECRET_ACCESS_KEY }}
225231
232+ - name : Login to Container Registries
233+ uses : ./.github/actions/docker-login
234+ with :
235+ azure_acr_hostname : ${{ secrets.AZURE_ACR_HOSTNAME }}
236+ azure_acr_user : ${{ secrets.AZURE_ACR_USER }}
237+ azure_acr_password : ${{ secrets.AZURE_ACR_PASSWORD }}
238+ ngc_ci_access_token : ${{ secrets.NGC_CI_ACCESS_TOKEN }}
226239 - name : Docker Tag and Push
227240 uses : ./.github/actions/docker-tag-push
228241 with :
229242 local_image : ${{ steps.build-image.outputs.image_tag }}
230- push_tag : ai-dynamo/dynamo:${{ github.sha }}-sglang-${{ matrix.platform.arch }}
243+ push_tags : ai-dynamo/dynamo:${{ github.sha }}-sglang-${{ matrix.platform.arch }}
231244 # OPS-1145: Switch aws_push to true
232245 aws_push : ' false'
233246 azure_push : ' true'
@@ -281,11 +294,18 @@ jobs:
281294 aws_access_key_id : ${{ secrets.AWS_ACCESS_KEY_ID }}
282295 aws_secret_access_key : ${{ secrets.AWS_SECRET_ACCESS_KEY }}
283296
297+ - name : Login to Container Registries
298+ uses : ./.github/actions/docker-login
299+ with :
300+ azure_acr_hostname : ${{ secrets.AZURE_ACR_HOSTNAME }}
301+ azure_acr_user : ${{ secrets.AZURE_ACR_USER }}
302+ azure_acr_password : ${{ secrets.AZURE_ACR_PASSWORD }}
303+ ngc_ci_access_token : ${{ secrets.NGC_CI_ACCESS_TOKEN }}
284304 - name : Docker Tag and Push
285305 uses : ./.github/actions/docker-tag-push
286306 with :
287307 local_image : ${{ steps.build-image.outputs.image_tag }}
288- push_tag : ai-dynamo/dynamo:${{ github.sha }}-trtllm-${{ matrix.platform.arch }}
308+ push_tags : ai-dynamo/dynamo:${{ github.sha }}-trtllm-${{ matrix.platform.arch }}
289309 # OPS-1145: Switch aws_push to true
290310 aws_push : ' false'
291311 azure_push : ' true'
0 commit comments