Skip to content

Commit db5687f

Browse files
hypdebrmccorm4
andauthored
fix: adjust usage of vLLM for deprecation of 'disable_log_requests' (#4659)
Co-authored-by: Ryan McCormick <[email protected]>
1 parent 2f2a13a commit db5687f

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

components/src/dynamo/vllm/args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ def overwrite_args(config):
464464
# skip tokenizer initialisation. Setting this to **False** avoids
465465
# a NoneType error when the processor accesses the tokenizer.
466466
"skip_tokenizer_init": False,
467-
"disable_log_requests": True,
467+
"enable_log_requests": False,
468468
"disable_log_stats": False,
469469
}
470470

components/src/dynamo/vllm/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def setup_vllm_engine(config, stat_logger=None):
296296
vllm_config=vllm_config,
297297
usage_context=usage_context,
298298
stat_loggers=factory,
299-
disable_log_requests=engine_args.disable_log_requests,
299+
enable_log_requests=engine_args.enable_log_requests,
300300
disable_log_stats=engine_args.disable_log_stats,
301301
)
302302

examples/multimodal/components/worker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def setup_vllm_engine(self, component: Component, endpoint: Endpoint):
142142
vllm_config=vllm_config,
143143
usage_context=usage_context,
144144
stat_loggers=[self.stats_logger],
145-
disable_log_requests=self.engine_args.disable_log_requests,
145+
enable_log_requests=self.engine_args.enable_log_requests,
146146
disable_log_stats=self.engine_args.disable_log_stats,
147147
)
148148

examples/multimodal/utils/args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def overwrite_args(config):
155155
defaults = {
156156
"task": "generate",
157157
"skip_tokenizer_init": False,
158-
"disable_log_requests": True,
158+
"enable_log_requests": False,
159159
"enable_prefix_caching": True,
160160
# KV routing relies on logging KV metrics
161161
"disable_log_stats": False,

0 commit comments

Comments
 (0)