Skip to content

Commit 52e7b92

Browse files
committed
remove unnecessary wrapper
Signed-off-by: Geoff Flarity <[email protected]>
1 parent e3d562f commit 52e7b92

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

operator/e2e/tests/gang_scheduling_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ package tests
2121
import (
2222
"context"
2323
"testing"
24+
25+
"github.com/ai-dynamo/grove/operator/e2e/utils"
2426
)
2527

2628
// Test_GS1_GangSchedulingWithFullReplicas tests gang-scheduling behavior with insufficient resources
@@ -149,7 +151,7 @@ func Test_GS2_GangSchedulingWithScalingFullReplicas(t *testing.T) {
149151
t.Fatalf("Failed to wait for scaled pods to be created: %v", err)
150152
}
151153

152-
if err := verifyPodPhases(tc, pods, expectedPods, 4); err != nil {
154+
if err := utils.VerifyPodPhases(pods, expectedPods, 4); err != nil {
153155
t.Fatalf("Pod phase verification failed: %v", err)
154156
}
155157

operator/e2e/tests/setup.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,6 @@ func waitForPodCountAndPhases(tc TestContext, expectedTotal, expectedRunning, ex
127127
return utils.WaitForPodCountAndPhases(tc.Ctx, tc.Clientset, tc.Namespace, tc.getLabelSelector(), expectedTotal, expectedRunning, expectedPending, tc.Timeout, tc.Interval)
128128
}
129129

130-
// verifyPodPhases is a wrapper around utils.VerifyPodPhases that accepts TestContext
131-
func verifyPodPhases(tc TestContext, pods *v1.PodList, expectedRunning, expectedPending int) error {
132-
return utils.VerifyPodPhases(pods, expectedRunning, expectedPending)
133-
}
134-
135130
// prepareTestCluster is a helper function that prepares the shared cluster for a test
136131
// with the specified number of worker nodes and returns the necessary clients and a cleanup function.
137132
// The cleanup function will fatally fail the test if workload cleanup fails.

0 commit comments

Comments
 (0)