feat!: Generalize build strategy terminology and add Kotlin build tools (#189)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Author: aaronsteers

connector_builder_mcp/build_strategies/base/build_strategy.py

@@ -26,8 +26,8 @@ class BuildStrategy(ABC):
 
     Variable domains (strategy-specific):
     - Guidance: Documentation and examples
-    - Manifest Checks: Validation without running connector
-    - Manifest Tests: Testing that runs the connector
+    - Validation: Validation without running connector
+    - Testing: Testing that runs the connector
     - Prompts: Workflow templates
 
     Global domains (shared, not in strategy):
@@ -75,8 +75,8 @@ def register_guidance_tools(cls, app: FastMCP) -> None:
 
     @classmethod
     @abstractmethod
-    def register_manifest_check_tools(cls, app: FastMCP) -> None:
-        """Register manifest check domain tools by calling registration functions.
+    def register_validation_tools(cls, app: FastMCP) -> None:
+        """Register validation domain tools by calling registration functions.
 
         Args:
             app: FastMCP application instance
@@ -85,8 +85,8 @@ def register_manifest_check_tools(cls, app: FastMCP) -> None:
 
     @classmethod
     @abstractmethod
-    def register_manifest_test_tools(cls, app: FastMCP) -> None:
-        """Register manifest test domain tools by calling registration functions.
+    def register_testing_tools(cls, app: FastMCP) -> None:
+        """Register testing domain tools by calling registration functions.
 
         Args:
             app: FastMCP application instance
@@ -115,8 +115,8 @@ def register_all_mcp_callables(cls, app: FastMCP) -> None:
             app: FastMCP application instance
         """
         cls.register_guidance_tools(app)
-        cls.register_manifest_check_tools(app)
-        cls.register_manifest_test_tools(app)
+        cls.register_validation_tools(app)
+        cls.register_testing_tools(app)
         cls.register_prompts(app)
 
     @classmethod

connector_builder_mcp/build_strategies/declarative_openapi_v3/build_strategy.py

@@ -42,14 +42,14 @@ def register_guidance_tools(cls, app: FastMCP) -> None:
         guidance.register_guidance_tools(app)
 
     @classmethod
-    def register_manifest_check_tools(cls, app: FastMCP) -> None:
-        """Register manifest check tools by calling the registration function."""
-        manifest_checks.register_manifest_check_tools(app)
+    def register_validation_tools(cls, app: FastMCP) -> None:
+        """Register validation tools by calling the registration function."""
+        manifest_checks.register_validation_tools(app)
 
     @classmethod
-    def register_manifest_test_tools(cls, app: FastMCP) -> None:
-        """Register manifest test tools by calling the registration function."""
-        manifest_tests.register_manifest_test_tools(app)
+    def register_testing_tools(cls, app: FastMCP) -> None:
+        """Register testing tools by calling the registration function."""
+        manifest_tests.register_testing_tools(app)
 
     @classmethod
     def register_prompts(cls, app: FastMCP) -> None:

connector_builder_mcp/build_strategies/declarative_openapi_v3/manifest_checks.py

@@ -1,4 +1,4 @@
-"""MANIFEST_CHECKS domain tools - Validation for OpenAPI/Sonar connectors.
+"""VALIDATION domain tools - Validation for OpenAPI/Sonar connectors.
 
 This module contains tools for validating OpenAPI specifications and connector
 configurations without actually running the connector.
@@ -26,7 +26,7 @@ class OpenApiValidationResult(BaseModel):
 
 
 @mcp_tool(
-    ToolDomain.MANIFEST_CHECKS,
+    ToolDomain.VALIDATION,
     read_only=True,
     idempotent=True,
     open_world=False,
@@ -88,10 +88,10 @@ def validate_openapi_spec(
     )
 
 
-def register_manifest_check_tools(app: FastMCP) -> None:
-    """Register manifest check tools with the FastMCP app.
+def register_validation_tools(app: FastMCP) -> None:
+    """Register validation tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_CHECKS)
+    register_mcp_tools(app, domain=ToolDomain.VALIDATION)

connector_builder_mcp/build_strategies/declarative_openapi_v3/manifest_tests.py

@@ -1,4 +1,4 @@
-"""MANIFEST_TESTS domain tools - Testing for OpenAPI/Sonar connectors.
+"""TESTING domain tools - Testing for OpenAPI/Sonar connectors.
 
 This module contains tools for testing OpenAPI-based connectors by actually
 running them against the API.
@@ -29,7 +29,7 @@ class ResourceTestResult(BaseModel):
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     open_world=True,
 )
 def test_openapi_resource(
@@ -91,10 +91,10 @@ def test_openapi_resource(
     )
 
 
-def register_manifest_test_tools(app: FastMCP) -> None:
-    """Register manifest test tools with the FastMCP app.
+def register_testing_tools(app: FastMCP) -> None:
+    """Register testing tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_TESTS)
+    register_mcp_tools(app, domain=ToolDomain.TESTING)

connector_builder_mcp/build_strategies/declarative_yaml_v1/build_strategy.py

@@ -46,14 +46,14 @@ def register_guidance_tools(cls, app: FastMCP) -> None:
         guidance.register_guidance_tools(app)
 
     @classmethod
-    def register_manifest_check_tools(cls, app: FastMCP) -> None:
-        """Register manifest check tools by calling the registration function."""
-        manifest_checks.register_manifest_check_tools(app)
+    def register_validation_tools(cls, app: FastMCP) -> None:
+        """Register validation tools by calling the registration function."""
+        manifest_checks.register_validation_tools(app)
 
     @classmethod
-    def register_manifest_test_tools(cls, app: FastMCP) -> None:
-        """Register manifest test tools by calling the registration function."""
-        manifest_tests.register_manifest_test_tools(app)
+    def register_testing_tools(cls, app: FastMCP) -> None:
+        """Register testing tools by calling the registration function."""
+        manifest_tests.register_testing_tools(app)
 
     @classmethod
     def register_prompts(cls, app: FastMCP) -> None:

connector_builder_mcp/build_strategies/declarative_yaml_v1/manifest_checks.py

@@ -1,4 +1,4 @@
-"""MANIFEST_CHECKS domain tools - Validation that doesn't run the connector.
+"""VALIDATION domain tools - Validation that doesn't run the connector.
 
 This module contains tools for validating manifest structure and syntax
 without actually running the connector.
@@ -27,7 +27,7 @@
 
 
 @mcp_tool(
-    ToolDomain.MANIFEST_CHECKS,
+    ToolDomain.VALIDATION,
     read_only=True,
     idempotent=True,
     open_world=False,
@@ -90,10 +90,10 @@ def validate_manifest(
     )
 
 
-def register_manifest_check_tools(app) -> None:
-    """Register manifest check tools with the FastMCP app.
+def register_validation_tools(app) -> None:
+    """Register validation tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_CHECKS)
+    register_mcp_tools(app, domain=ToolDomain.VALIDATION)

connector_builder_mcp/build_strategies/declarative_yaml_v1/manifest_tests.py

@@ -1,4 +1,4 @@
-"""MANIFEST_TESTS domain tools - Testing that runs the connector.
+"""TESTING domain tools - Testing that runs the connector.
 
 This module contains tools for testing connectors by actually running them.
 """
@@ -480,7 +480,7 @@ def _format_validation_error(
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     read_only=True,
     open_world=True,
 )
@@ -543,7 +543,7 @@ def validate_manifest(
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     open_world=True,
 )
 def execute_stream_test_read(  # noqa: PLR0914
@@ -841,7 +841,7 @@ def _as_saved_report(
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     read_only=True,
     open_world=True,
 )
@@ -1143,7 +1143,7 @@ def run_connector_readiness_test_report(  # noqa: PLR0912, PLR0914, PLR0915 (too
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     read_only=True,
 )
 def execute_dynamic_manifest_resolution_test(
@@ -1217,10 +1217,10 @@ def execute_dynamic_manifest_resolution_test(
     return "Failed to resolve manifest"
 
 
-def register_manifest_test_tools(app: FastMCP) -> None:
-    """Register manifest test tools with the FastMCP app.
+def register_testing_tools(app: FastMCP) -> None:
+    """Register testing tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_TESTS)
+    register_mcp_tools(app, domain=ToolDomain.TESTING)

connector_builder_mcp/build_strategies/kotlin_destination/build_strategy.py

@@ -58,14 +58,14 @@ def register_guidance_tools(cls, app: FastMCP) -> None:
         guidance.register_guidance_tools(app)
 
     @classmethod
-    def register_manifest_check_tools(cls, app: FastMCP) -> None:
-        """Register manifest check tools by calling the registration function."""
-        manifest_checks.register_manifest_check_tools(app)
+    def register_validation_tools(cls, app: FastMCP) -> None:
+        """Register validation tools by calling the registration function."""
+        manifest_checks.register_validation_tools(app)
 
     @classmethod
-    def register_manifest_test_tools(cls, app: FastMCP) -> None:
-        """Register manifest test tools by calling the registration function."""
-        manifest_tests.register_manifest_test_tools(app)
+    def register_testing_tools(cls, app: FastMCP) -> None:
+        """Register testing tools by calling the registration function."""
+        manifest_tests.register_testing_tools(app)
 
     @classmethod
     def register_prompts(cls, app: FastMCP) -> None:

connector_builder_mcp/build_strategies/kotlin_destination/manifest_checks.py

@@ -1,4 +1,4 @@
-"""MANIFEST_CHECKS domain tools - Validation for Kotlin destination connectors.
+"""VALIDATION domain tools - Validation for Kotlin destination connectors.
 
 This module contains tools for validating Kotlin destination connector code and
 configuration without actually running the connector.
@@ -26,7 +26,7 @@ class KotlinDestinationValidationResult(BaseModel):
 
 
 @mcp_tool(
-    ToolDomain.MANIFEST_CHECKS,
+    ToolDomain.VALIDATION,
     read_only=True,
     idempotent=True,
     open_world=False,
@@ -73,10 +73,10 @@ def validate_kotlin_destination_connector(
     )
 
 
-def register_manifest_check_tools(app: FastMCP) -> None:
-    """Register manifest check tools with the FastMCP app.
+def register_validation_tools(app: FastMCP) -> None:
+    """Register validation tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_CHECKS)
+    register_mcp_tools(app, domain=ToolDomain.VALIDATION)

connector_builder_mcp/build_strategies/kotlin_destination/manifest_tests.py

@@ -1,4 +1,4 @@
-"""MANIFEST_TESTS domain tools - Testing for Kotlin destination connectors.
+"""TESTING domain tools - Testing for Kotlin destination connectors.
 
 This module contains tools for testing Kotlin destination connectors by actually
 running them against the destination system.
@@ -26,7 +26,7 @@ class KotlinDestinationTestResult(BaseModel):
 
 
 @mcp_tool(
-    domain=ToolDomain.MANIFEST_TESTS,
+    domain=ToolDomain.TESTING,
     open_world=True,
 )
 def test_kotlin_destination_write(
@@ -92,10 +92,10 @@ def test_kotlin_destination_write(
     )
 
 
-def register_manifest_test_tools(app: FastMCP) -> None:
-    """Register manifest test tools with the FastMCP app.
+def register_testing_tools(app: FastMCP) -> None:
+    """Register testing tools with the FastMCP app.
 
     Args:
         app: FastMCP application instance
     """
-    register_mcp_tools(app, domain=ToolDomain.MANIFEST_TESTS)
+    register_mcp_tools(app, domain=ToolDomain.TESTING)