Skip to content

Conversation

@hnousiainen
Copy link
Contributor

Implement initial support for CMK operations.

@hnousiainen hnousiainen requested review from a team as code owners November 26, 2025 07:41
@hnousiainen hnousiainen requested a review from Prime541 November 26, 2025 07:41
Copy link

@glenn-mcallister-aiven glenn-mcallister-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to block this, for a couple of reason:

  1. Most of these commands are using optional style arguments (i.e., --cmk-id) for required arguments. That's a major UX no-no.
  2. WAY MORE significantly, the current implementation is intended for BMC only, to the point where
    1. we are hiding access to the the API behind an ACL,
    2. we aren't documenting the API in our public API docs,
    3. BMC does changes only through TF, meaning they need API access only.

Once these changes get published, customers are going to see that there are "customer managed keys" commands, which is 100% what we don't want currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants