fix(postgres): fixed potential panic in PostgreSQL controller (#1034)

vmyroslav · web-flow · commit 4cdfdd8362df · 2025-10-08T11:10:06.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## [MAJOR.MINOR.PATCH] - YYYY-MM-DD
 
+- Fix `PostgreSQL`: resolved panic during upgrade check task fails
+
 ## v0.33.0 - 2025-09-30
 
 - **DEPRECATION**: `AlloyDBOmni` is deprecated and entering its end-of-life cycle. See <https://aiven.io/docs/platform/reference/end-of-life> for details
diff --git a/controllers/postgresql_controller.go b/controllers/postgresql_controller.go
@@ -128,7 +128,7 @@ func (a *postgreSQLAdapter) performUpgradeTaskIfNeeded(ctx context.Context, avnG
 	finalTaskResult, err := waitForTaskToComplete(ctx, func() (bool, *service.ServiceTaskGetOut, error) {
 		t, getErr := avnGen.ServiceTaskGet(ctx, a.getServiceCommonSpec().Project, a.getObjectMeta().Name, task.TaskId)
 		if getErr != nil {
-			return true, nil, fmt.Errorf("error fetching service task %s: %w", t.TaskId, getErr)
+			return true, nil, fmt.Errorf("error fetching service task %s: %w", task.TaskId, getErr)
 		}
 
 		if !t.Success {

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ func (a *postgreSQLAdapter) performUpgradeTaskIfNeeded(ctx context.Context, avnG`
`128`	`128`	`finalTaskResult, err := waitForTaskToComplete(ctx, func() (bool, *service.ServiceTaskGetOut, error) {`
`129`	`129`	`t, getErr := avnGen.ServiceTaskGet(ctx, a.getServiceCommonSpec().Project, a.getObjectMeta().Name, task.TaskId)`
`130`	`130`	`if getErr != nil {`
`131`		`- return true, nil, fmt.Errorf("error fetching service task %s: %w", t.TaskId, getErr)`
	`131`	`+ return true, nil, fmt.Errorf("error fetching service task %s: %w", task.TaskId, getErr)`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`if !t.Success {`