-
Notifications
You must be signed in to change notification settings - Fork 291
Allow forceString when setting helm chart values. #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This fixes: #4793 |
|
@johnthompson-ybor please be patient. We have a few team members on PTO, so we have a bit of a backlog on reviews. Reviews are also prioritized on the basis of our own, internal priorities. We will get to this when we are able. |
| | `setValues` | `[]object` | N | Allows for amending chart configuration inline as one would with the `helm template` command's `--set` flag. | | ||
| | `setValues[].key` | `string` | N | The key whose value should be set. For nested values, use dots to delimit key parts. e.g. `image.tag`. | | ||
| | `setValues[].value` | `string` | N | The new value for the key. | | ||
| | `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more intuitive to name this literal to match the Helm flag?
| | `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. | | |
| | `setValues[].literal` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. | |
|
I wanted to match the argocd spec
…On Mon, Sep 1, 2025 at 8:32 AM Hidde Beydals ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/helm-template.md
<#4921 (comment)>:
> @@ -31,6 +31,7 @@ commonly preceded by a [`git-clear` step](git-clear.md) and followed by
| `setValues` | `[]object` | N | Allows for amending chart configuration inline as one would with the `helm template` command's `--set` flag. |
| `setValues[].key` | `string` | N | The key whose value should be set. For nested values, use dots to delimit key parts. e.g. `image.tag`. |
| `setValues[].value` | `string` | N | The new value for the key. |
+| `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |
Would it be more intuitive to name this literal to match the Helm flag?
⬇️ Suggested change
-| `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |
+| `setValues[].literal` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |
—
Reply to this email directly, view it on GitHub
<#4921 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLSXU7A3BBO6RNE4ASHTC3D3QQ4HXAVCNFSM6AAAAACEPOKNNGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNZTGQ3DMOJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As a general rule, we try to match the vernacular of the tool or tech we're integrating with. Argo CD doesn't have any relevance to the |
|
This doesn't seem like it will make the cut for v1.8.0. Moving to v1.9.0. @johnthompson-ybor as this feature was unsolicited, the PR is likely to eventually be closed if it's been abandoned. |
This allows similar behavior to argo cd values so that when you use force string on a value is treats it as a string literal instead of something to be parsed further.
This is relevant for any value which contains commas, for example, or any value which is roughly json shaped, which helm will otherwise try to parse.
Will cause an error in the current code.
Will work appropriately after this PR is merged. This basically duplicates the existing ArgoCD spec for key/value pairs in helm charts.