Skip to content

Conversation

@johnthompson-ybor
Copy link

This allows similar behavior to argo cd values so that when you use force string on a value is treats it as a string literal instead of something to be parsed further.

This is relevant for any value which contains commas, for example, or any value which is roughly json shaped, which helm will otherwise try to parse.

- name: comma_delimited_list
   value: foo,bar,baz

Will cause an error in the current code.

- name: comma_delimited_list
   value: foo,bar,baz
   forceString: true

Will work appropriately after this PR is merged. This basically duplicates the existing ArgoCD spec for key/value pairs in helm charts.

@johnthompson-ybor johnthompson-ybor requested review from a team as code owners August 21, 2025 17:56
@netlify
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 38b7feb
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/68a75de6c33b470008ddb35e
😎 Deploy Preview https://deploy-preview-4921.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@johnthompson-ybor johnthompson-ybor changed the title Allow forceString when setting argocd values. Allow forceString when setting helm chart values. Aug 21, 2025
@johnthompson-ybor
Copy link
Author

This fixes: #4793

@krancour
Copy link
Member

@johnthompson-ybor please be patient. We have a few team members on PTO, so we have a bit of a backlog on reviews. Reviews are also prioritized on the basis of our own, internal priorities. We will get to this when we are able.

| `setValues` | `[]object` | N | Allows for amending chart configuration inline as one would with the `helm template` command's `--set` flag. |
| `setValues[].key` | `string` | N | The key whose value should be set. For nested values, use dots to delimit key parts. e.g. `image.tag`. |
| `setValues[].value` | `string` | N | The new value for the key. |
| `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more intuitive to name this literal to match the Helm flag?

Suggested change
| `setValues[].forceString` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |
| `setValues[].literal` | `boolean` | N | Whether to force the value to be treated as a string. When true, uses `--set-literal` instead of `--set`. This is `false` by default. |

@johnthompson-ybor
Copy link
Author

johnthompson-ybor commented Sep 2, 2025 via email

@krancour
Copy link
Member

krancour commented Sep 8, 2025

I wanted to match the argocd spec

As a general rule, we try to match the vernacular of the tool or tech we're integrating with.

Argo CD doesn't have any relevance to the helm-template step, but helm has.

@krancour krancour added kind/enhancement An entirely new feature priority/normal This is the priority for most work area/controller Affects the (main) controller labels Sep 8, 2025
@krancour krancour added this to the v1.8.0 milestone Sep 8, 2025
@krancour
Copy link
Member

krancour commented Oct 2, 2025

This doesn't seem like it will make the cut for v1.8.0.

Moving to v1.9.0.

@johnthompson-ybor as this feature was unsolicited, the PR is likely to eventually be closed if it's been abandoned.

@krancour krancour modified the milestones: v1.8.0, v1.9.0 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Affects the (main) controller kind/enhancement An entirely new feature priority/normal This is the priority for most work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants