Skip to content

Conversation

@sipercai
Copy link
Collaborator

@sipercai sipercai commented Nov 17, 2025

Description

This PR fixes linting errors and test setup issues in the instrumentation-loongsuite packages to ensure code quality and testability.

Fixes #63

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

tox -e precommit

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@sipercai sipercai force-pushed the fix/instrumentation-loongsuite-linting branch from e384b46 to e4a3645 Compare November 17, 2025 12:36
@Cirilla-zmh Cirilla-zmh added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 18, 2025
@ralf0131
Copy link
Collaborator

ralf0131 commented Dec 2, 2025

@sipercai Could you fix the failing checking?

@Cirilla-zmh
Copy link
Collaborator

@sipercai Just rebase the main branch and these PR checks may be resolved.

… packages

- Fix linting errors (PLC0415, A001/A002, E501, F401, F841, I001) in:
  - loongsuite-instrumentation-agentscope: variable shadowing, import order, unused variables
  - loongsuite-instrumentation-agno: import order, variable shadowing, dictionary iteration
  - loongsuite-instrumentation-langchain: long line URLs, import order

- Fix test setup issues:
  - Add opentelemetry-instrumentation dependency to agno package
  - Add test dependencies (openai, yfinance) for agno tests
  - Add conftest.py for agentscope tests to configure Python path
  - Fix import paths and version detection utilities

- Break down long URL comments into multiple lines to comply with line length limits

Change-Id: I746644dabeed4f0bd32603ba2c96fb712501d689
Co-developed-by: Cursor <[email protected]>
@sipercai sipercai force-pushed the fix/instrumentation-loongsuite-linting branch from e4a3645 to d862393 Compare December 2, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the failure of ruff check in loongsuite instrumentations.

4 participants