Skip to content

Commit 7d9871c

Browse files
authored
Fix deprecated Log4j2 package scanning warnings (#13902)
* fix: deprecated Log4j2 package scanning warnings * fix: replace log4j2.version property with log4j.version in log4j2-adapter
1 parent 7e7da4e commit 7d9871c

File tree

3 files changed

+24
-4
lines changed

3 files changed

+24
-4
lines changed

logger-adapter-impl/log4j2-adapter/pom.xml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,24 @@
5656
<optional>true</optional>
5757
</dependency>
5858
</dependencies>
59+
60+
<build>
61+
<plugins>
62+
<!-- Log4j annotation processor plugin -->
63+
<plugin>
64+
<groupId>org.apache.maven.plugins</groupId>
65+
<artifactId>maven-compiler-plugin</artifactId>
66+
<configuration>
67+
<annotationProcessorPaths>
68+
<path>
69+
<groupId>org.apache.logging.log4j</groupId>
70+
<artifactId>log4j-core</artifactId>
71+
<version>${log4j.version}</version>
72+
</path>
73+
</annotationProcessorPaths>
74+
</configuration>
75+
</plugin>
76+
</plugins>
77+
</build>
5978

6079
</project>

logger-adapter-impl/log4j2-adapter/src/main/java/com/alibaba/nacos/logger/adapter/log4j2/Log4J2NacosLoggingAdapter.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ public class Log4J2NacosLoggingAdapter implements NacosLoggingAdapter {
4848

4949
private static final String NACOS_LOGGER_PREFIX = "com.alibaba.nacos";
5050

51-
private static final String NACOS_LOG4J2_PLUGIN_PACKAGE = "com.alibaba.nacos.client.logging.log4j2";
52-
5351
private static final String APPENDER_MARK = "ASYNC_NAMING";
5452

5553
private static final String LOG4J2_CLASSES = "org.apache.logging.slf4j.Log4jLogger";
@@ -101,7 +99,6 @@ private void loadConfiguration(String location) {
10199

102100
// load and start nacos configuration
103101
Configuration configuration = loadConfiguration(loggerContext, location);
104-
configuration.getPluginPackages().add(NACOS_LOG4J2_PLUGIN_PACKAGE);
105102
configuration.start();
106103

107104
// append loggers and appenders to contextConfiguration

logger-adapter-impl/log4j2-adapter/src/main/resources/nacos-log4j2.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
<AppenderRef ref="NAMING_LOG_FILE"/>
9292
</Async>
9393

94-
<RollingFile name="AI_LOG_FILE" fileName="${logPath}/nacos/naming.log"
94+
<RollingFile name="AI_LOG_FILE" fileName="${logPath}/nacos/ai.log"
9595
filePattern="${logPath}/nacos/ai.log.%d{yyyy-MM-dd}.%i">
9696
<PatternLayout>
9797
<Pattern>%d{yyyy-MM-dd HH:mm:ss.SSS} %p [%-5t:%c{2}] %m%n</Pattern>
@@ -151,5 +151,9 @@
151151
additivity="false">
152152
<AppenderRef ref="ASYNC_AI"/>
153153
</Logger>
154+
155+
<Root level="${nacosClientProperty:root.log.level:-WARN}">
156+
<AppenderRef ref="ASYNC_CONFIG"/>
157+
</Root>
154158
</Loggers>
155159
</Configuration>

0 commit comments

Comments
 (0)