Skip to content

Migrate task management from Makefile to mise#58

Merged
amrabed merged 7 commits into
mainfrom
migrate-to-mise-15288307572828242440
May 23, 2026
Merged

Migrate task management from Makefile to mise#58
amrabed merged 7 commits into
mainfrom
migrate-to-mise-15288307572828242440

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This PR replaces the project's Makefile with a mise.toml configuration, following the official Node.js cookbook. Key changes include:

  • Added mise.toml with tasks for install, build, dev (aliased to local), lint, format, and firebase deployment.
  • Optimized the 'install' task with caching using 'sources' and 'outputs'.
  • Added 'node_modules/.bin' to the PATH in mise.toml.
  • Updated GitHub Workflows to use jdx/mise-action and mise run commands.
  • Removed the deprecated Makefile and the redundant package-lock.json (consolidated on pnpm).

PR created automatically by Jules for task 15288307572828242440 started by @amrabed

@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Added pnpm to mise.toml tools to ensure it's available in CI environments.
- Upgraded jdx/mise-action to v4 to resolve Node.js 20 deprecation warnings.
- Switched pnpm to use the npm backend in mise.toml to avoid aqua attestation verification 401 errors in CI.
- Removed redundant actions/setup-node from check and deploy workflows as mise-action manages Node.js.
- Updated mise.toml to use "npm:pnpm" backend to avoid artifact attestation verification failures in CI.
- Added mise.toml to install task sources for better caching.
- Cleaned up GitHub workflows by removing redundant actions/setup-node.
- Normalized package.json by moving overrides out of the pnpm field.
- Refreshed pnpm-lock.yaml to match the updated package.json.
Comment thread mise.toml
Comment thread mise.toml
- Added one-letter aliases for mise tasks.
- Implemented shell aliases in mise.toml.
- Ensured 'lint' task depends on 'format'.
- Fixed package.json pnpm overrides to ensure correct version resolution.
- Updated pnpm-lock.yaml.
Comment thread .github/workflows/check.yml Outdated
Comment thread .github/workflows/deploy.yml Outdated
Comment thread .github/workflows/firebase.yml Outdated
google-labs-jules Bot and others added 2 commits May 23, 2026 18:30
- Updated mise.toml tasks (lint, build) to depend on 'install' to ensure dependencies are present in CI.
- Added firebase-tools to mise.toml tools for better management.
- Cleaned up firebase workflow by removing manual install task call.
- Ensured consistent task and shell aliases are present.
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@amrabed amrabed marked this pull request as ready for review May 23, 2026 20:30
@amrabed amrabed merged commit 50a37eb into main May 23, 2026
2 of 4 checks passed
@amrabed amrabed deleted the migrate-to-mise-15288307572828242440 branch May 23, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant