Skip to content

Refactor duplicated UI components to address Sonar scan failures#61

Merged
amrabed merged 1 commit into
mainfrom
fix/code-duplication-sonar-5231556884773163315
May 23, 2026
Merged

Refactor duplicated UI components to address Sonar scan failures#61
amrabed merged 1 commit into
mainfrom
fix/code-duplication-sonar-5231556884773163315

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This PR addresses code duplication issues identified by Sonar scans by extracting repeated UI patterns into reusable components.

Key changes:

  1. Created src/components/icon-link.tsx to unify tooltipped external links used in Project and Publication cards.
  2. Created src/components/section-item-card.tsx to unify the card layout used for items in the Certifications and Education sections.
  3. Updated relevant components to use these new shared components, ensuring visual consistency and improved maintainability.
  4. Verified changes through frontend screenshots and ensured pnpm build and pnpm lint pass successfully.

PR created automatically by Jules for task 5231556884773163315 started by @amrabed

- Extract shared `IconLink` component from `ProjectView` and `PublicationView`.
- Extract shared `SectionItemCard` component for `CertificationsSection` and `EducationSection`.
- Clean up unused imports and verify consistent UI rendering.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud
Copy link
Copy Markdown

@amrabed amrabed marked this pull request as ready for review May 23, 2026 21:01
@amrabed amrabed merged commit f8bb689 into main May 23, 2026
5 checks passed
@amrabed amrabed deleted the fix/code-duplication-sonar-5231556884773163315 branch May 23, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant