Deprecate ffmpeg-python

Author: andrewwkimm

pyproject.toml

@@ -10,7 +10,6 @@ requires-python = ">=3.10"
 dependencies = [
     "faster-whisper>=1.0.3",
     "transformers>=4.39.3",
-    "ffmpeg-python>=0.2.0",
     "torch>=2.2.2",
     "accelerate>=0.29.3",
     "cyclopts>=2.9.9",

src/koffee/overlay.py

@@ -1,10 +1,9 @@
 """Subtitle overlayer."""
 
 import logging
+import subprocess
 from pathlib import Path
 
-import ffmpeg
-
 from koffee.exceptions import SubtitleOverlayError
 
 log = logging.getLogger(__name__)
@@ -18,12 +17,25 @@ def overlay_subtitles(
     """Overlay subtitles to a video file."""
     log.info("Overlaying subtitles.")
 
+    cmd = [
+        "ffmpeg",
+        "-i",
+        str(video_file_path),
+        "-i",
+        str(subtitle_file_path),
+        "-c",
+        "copy",
+        "-c:s",
+        "mov_text",
+        "-metadata:s:s:0",
+        "language=eng",
+        "-y",
+        str(output_file_path),
+    ]
+
     try:
-        ffmpeg.input(video_file_path).output(
-            str(output_file_path), vf=f"subtitles={subtitle_file_path}"
-        ).run(overwrite_output=True, capture_stdout=True, capture_stderr=True)
-    except ffmpeg.Error as error:
-        error_message = error.stderr.decode("utf-8")
-        raise SubtitleOverlayError(error_message) from error
+        subprocess.run(cmd, capture_output=True, text=True, check=True)
+    except subprocess.CalledProcessError as error:
+        raise SubtitleOverlayError(error.stderr) from error
 
     return output_file_path

tests/test_overlay.py

@@ -1,8 +1,8 @@
 """Tests for subtitle overlay."""
 
+import subprocess
 from pathlib import Path
 
-import ffmpeg
 import pytest
 from pytest_mock import MockerFixture
 
@@ -44,10 +44,15 @@ def test_exception_handling(
     mocker: MockerFixture,
 ) -> None:
     """Tests that exception is caught and an error is raised."""
-    mocker.patch("ffmpeg.input", side_effect=ffmpeg.Error("ffmpeg", "", b"FFmpegError"))
+    mocker.patch(
+        "subprocess.run",
+        side_effect=subprocess.CalledProcessError(
+            returncode=1, cmd=["ffmpeg"], stderr="FFmpegError"
+        ),
+    )
 
     with pytest.raises(SubtitleOverlayError) as exc_info:
         overlay_subtitles(subtitle_file_path, video_file_path, output_file_path)
 
-    assert isinstance(exc_info.value.__cause__, ffmpeg.Error)
+    assert isinstance(exc_info.value.__cause__, subprocess.CalledProcessError)
     assert "FFmpegError" in str(exc_info.value)