Improvements to support Windows #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server, which is unlikely to be the end-user platform.
anirbanbasu
added
bug
Owner
Author
|
Partly fixes #20 but HF model download issues are not Windows-specific, so that will be handled in a separate PR. |
dosubot
bot
added
the
size:M
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows support to the ollama-downloader project by implementing platform-specific compatibility fixes and adding Windows-specific test coverage.
Key changes:
- Added Windows compatibility by conditionally importing Unix-specific modules
- Enhanced error handling with more detailed HTTP error messages
- Fixed path handling to use cross-platform compatible methods
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ollama_downloader/sysinfo.py | Added conditional import of grp module for Unix/Linux compatibility |
| src/ollama_downloader/cli.py | Enhanced error logging with HTTP response details |
| src/ollama_downloader/data/data_models.py | Updated default path construction for cross-platform compatibility |
| src/ollama_downloader/init.py | Changed path separator to use os.path.join for Windows compatibility |
| src/ollama_downloader/downloader/model_downloader.py | Fixed variable scoping by moving model/tag parsing before match statement |
| src/ollama_downloader/downloader/hf_model_downloader.py | Added default handling for missing tag in model identifier |
| pyproject.toml | Added Windows-specific pywin32 dependency |
| .github/workflows/uv-pytest.yml | Updated workflow naming and removed comments |
| tests_on_windows.txt | Added list of Windows-compatible tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Anirban Basu <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Anirban Basu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #20