-
Notifications
You must be signed in to change notification settings - Fork 79
release: 1.19.1 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
release: 1.19.1 #256
Conversation
copy from next without all message utils add utils revert diffs for betamessage migrate param utils
add more to param converters
…m-fixes fix: update accumulators and param converters
packyg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things plus:
- Can we add a conventional commit message so we get a changelog?
- Could we also add a unit test to explicitly test the issue from #164 ?
| p := variant.ToParam() | ||
| return ContentBlockParamUnion{OfWebSearchToolResult: &p} | ||
| default: | ||
| panic(fmt.Sprintf("unexpected anthropic.anyContentBlock: %#v", variant)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not panic and perhaps log something here instead and then return like we do for beta?
| panic(fmt.Sprintf("unexpected anthropic.anyContentBlock: %#v", variant)) | |
| return ContentBlockParamUnion{} |
There's some risk we forget a new content block type here. That or add a unit test to catch some cases.
|
|
||
| // Param converters | ||
|
|
||
| func (r BetaContentBlockUnion) ToParam() BetaContentBlockParamUnion { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like BetaToolSearchToolResultBlock is missing, could we add that?
| // } | ||
| func (acc *Message) Accumulate(event MessageStreamEventUnion) error { | ||
| if acc == nil { | ||
| return fmt.Errorf("accumulate: cannot accumlate into nil Message") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return fmt.Errorf("accumulate: cannot accumlate into nil Message") | |
| return fmt.Errorf("accumulate: cannot accumulate into nil Message") |
1456002 to
ba13a14
Compare
f35ec3d to
db37e73
Compare
35b8e9e to
9398b8b
Compare
9398b8b to
0b7cf94
Compare
0b7cf94 to
f003ce9
Compare
f003ce9 to
e0b17e1
Compare
e0b17e1 to
3e9a487
Compare
3e9a487 to
aa8de63
Compare
Automated Release PR
1.19.1 (2025-12-06)
Full Changelog: v1.19.0...v1.19.1
Bug Fixes
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions