clean code

Author: Abacn

sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java

@@ -36,6 +36,7 @@
 import java.util.Objects;
 import java.util.UUID;
 import java.util.concurrent.TimeUnit;
+import java.util.function.Function;
 import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 import net.bytebuddy.description.type.TypeDescription.ForLoadedType;
@@ -97,6 +98,7 @@
 import org.apache.beam.sdk.values.Row;
 import org.apache.beam.sdk.values.TypeDescriptor;
 import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.CaseFormat;
+import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap;
 import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables;
 import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Lists;
 import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Maps;
@@ -1214,14 +1216,13 @@ private static org.apache.avro.Schema getFieldSchema(
     return fieldType.getNullable() ? ReflectData.makeNullable(baseType) : baseType;
   }
 
-  private static final org.apache.avro.Schema INT_AVRO_TYPE =
-      org.apache.avro.Schema.create(Type.INT);
-  private static final org.apache.avro.Schema LONG_AVRO_TYPE =
-      org.apache.avro.Schema.create(Type.LONG);
-  private static final org.apache.avro.Schema FLOAT_AVRO_TYPE =
-      org.apache.avro.Schema.create(Type.FLOAT);
-  private static final org.apache.avro.Schema DOUBLE_AVRO_TYPE =
-      org.apache.avro.Schema.create(Type.DOUBLE);
+  private static final Map<org.apache.avro.Schema, Function<Number, ? extends Number>>
+      NUMERIC_CONVERTERS =
+          ImmutableMap.of(
+              org.apache.avro.Schema.create(Type.INT), Number::intValue,
+              org.apache.avro.Schema.create(Type.LONG), Number::longValue,
+              org.apache.avro.Schema.create(Type.FLOAT), Number::floatValue,
+              org.apache.avro.Schema.create(Type.DOUBLE), Number::doubleValue);
 
   /** Convert a value from Beam Row to a vlue used for Avro GenericRecord. */
   private static @Nullable Object genericFromBeamField(
@@ -1240,15 +1241,8 @@ private static org.apache.avro.Schema getFieldSchema(
       return value;
     }
 
-    // Handle implicit up-cast: use avroSchema
-    if (INT_AVRO_TYPE.equals(typeWithNullability.type)) {
-      return ((Number) value).intValue();
-    } else if (LONG_AVRO_TYPE.equals(typeWithNullability.type)) {
-      return ((Number) value).longValue();
-    } else if (FLOAT_AVRO_TYPE.equals(typeWithNullability.type)) {
-      return ((Number) value).floatValue();
-    } else if (DOUBLE_AVRO_TYPE.equals(typeWithNullability.type)) {
-      return ((Number) value).doubleValue();
+    if (NUMERIC_CONVERTERS.containsKey(typeWithNullability.type)) {
+      return NUMERIC_CONVERTERS.get(typeWithNullability.type).apply((Number) value);
     }
 
     // TODO: should we use Avro Schema as the source-of-truth in general?