Add Iceberg Schema Support for PassThroughLogicalType #36870
+121
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarun-google
commented
Nov 20, 2025
| String logicalTypeIdentifier = | ||
| checkArgumentNotNull(beamType.getLogicalType()).getIdentifier(); | ||
| Schema.LogicalType<?, ?> logicalType = checkArgumentNotNull(beamType.getLogicalType()); | ||
| if (logicalType instanceof FixedPrecisionNumeric) { |
Contributor
Author
There was a problem hiding this comment.
not fully sure if this is the right way. But DecimalType need inputs of precision and scale. which is not the case with other types
Contributor
There was a problem hiding this comment.
parametrized timestamp type may be another case. cc: @claudevdm
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
ahmedabu98
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36864
Adding Schema Iceberg support for PassThroughLogicalType
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.