Skip to content

Conversation

@pacoavila808
Copy link

@pacoavila808 pacoavila808 commented Nov 26, 2025

Enables setting the Firestore database on the transform level of the FirestoreV1ReadFn, enabling pipelines to configure operations across multiple different databases.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pacoavila808, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Apache Beam Firestore connector by introducing the capability to explicitly define the target Firestore database for both read and write operations at the transform level. This change provides greater flexibility for users, enabling pipelines to seamlessly interact with and manage data across multiple Firestore databases within a single Beam job. The core modification involves updating the internal FirestoreStatefulComponentFactory to accept and prioritize explicit database and project IDs, which are then propagated through various FirestoreV1 transforms.

Highlights

  • Database Specification for FirestoreV1ReadFn: Introduced the ability to specify the Firestore database ID directly within FirestoreV1ReadFn transforms, allowing for more granular control over data operations.
  • Flexible Database Operations: This enhancement enables Apache Beam pipelines to configure and perform operations across multiple distinct Firestore databases within a single job.
  • API Enhancements: The FirestoreStatefulComponentFactory now includes an overloaded getFirestoreStub method to accept explicit project and database IDs, which are prioritized over values from PipelineOptions.
  • Read and Write Transform Updates: All FirestoreV1 read operations (ListCollectionIds, ListDocuments, RunQuery, BatchGetDocuments, PartitionQuery) and write operations have been updated to propagate and utilize the new database ID parameter.
  • Comprehensive Testing: Existing unit and integration tests have been updated and expanded to cover the new database specification functionality, ensuring reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pacoavila808
Copy link
Author

R: @yixiaoshen @kennknowles

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant