Skip to content

Commit d6e0c94

Browse files
committed
Fix Checkstyle and PMD errors
1 parent e2ecc02 commit d6e0c94

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/main/java/org/apache/commons/jxpath/ri/JXPathClassFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,5 @@ public interface JXPathClassFilter {
3737
* passed.
3838
* @return true if the java class can be exposed via xpath, false otherwise
3939
*/
40-
public boolean exposeToXPath(String className);
40+
boolean exposeToXPath(String className);
4141
}

src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* @version $Revision$ $Date$
3131
*/
3232
public class JXPathFilter implements JXPathClassFilter {
33-
Set<String> allowedClassesList = null;
33+
private Set<String> allowedClassesList = null;
3434

3535
public JXPathFilter() {
3636
init();
@@ -39,7 +39,7 @@ public JXPathFilter() {
3939
public void init() {
4040
String restrictedClasses = System.getProperty("jxpath.class.allow");
4141
allowedClassesList = null;
42-
if ((restrictedClasses != null) && (restrictedClasses.trim().length() > 0)) {
42+
if (restrictedClasses != null && restrictedClasses.trim().length() > 0) {
4343
allowedClassesList = new HashSet<>();
4444
allowedClassesList.addAll(Arrays.asList(restrictedClasses.split(",")));
4545
}
@@ -54,15 +54,11 @@ public void init() {
5454
*/
5555
@Override
5656
public boolean exposeToXPath(String className) {
57-
if ((allowedClassesList == null) || (allowedClassesList.size() < 1)) {
57+
if (allowedClassesList == null || allowedClassesList.size() < 1) {
5858
return false;
5959
}
6060

61-
if (allowedClassesList.contains(className) || allowedClassesList.contains("*")) {
62-
return true;
63-
}
64-
65-
return false;
61+
return allowedClassesList.contains(className) || allowedClassesList.contains("*");
6662
}
6763
}
6864

0 commit comments

Comments
 (0)