Data Editor Processes Continue After Exiting VS Code

[rthomas320]

I noticed this issue on WIndows10. Two data editor processes continue to run after closing the debug window running the data editor in the extension and the original VS Code window.

Steps to Reproduce

1. pull in the code for main
2. make sure main is checked out
3. run git clean -fdx
4. run yarn
5. start VS Code -> code .
6. start the debugger to run the extension in debug
7. when the debug vs code window opens, use ctrl+shift+p to launch the data editor
8. pick a file to open
9. close the debug vs code window
10. close the original vs code window
11. run git clean -fdx
12. git clean will produce an error
13. open task manager
14. a Java process will show as running
15. stop the Java process
16. run git clean -fdx
17. git clean will complete successfully

Expected Behavior

Git clean should successfully remove the indicated files without having to stop the Java process. Exiting visual studio should stop the data editor java processes

Actual Behavior

Git clean is unable to remove the files:

• node_modules/@omega-edit/server/out/bin/omega-edit-grpc-server
• node_modules/@omega-edit/server/out/bin/omega-edit-grepc-server.bat
  data editor Java processes continue to run

Additional Notes and Screenshots (optional)

I ran git clean, then yarn,
then brought up the source in code and ran the extension in debug.
I opened DataEditor from the control palette,
then tried a search and replace operation.
I closed the extension window,
then the original code window
and ran git clean again.
I got an error that a node module that had to do with DataEditor couldn't be deleted.
I checked Task Manager and Java was running.

I canceled out of the git clean.
Stopped the Java task.
then ran git clean again.
Git clean completed successfully.

Environment

• Operating System(s):
  WIndows10
• Browser/VS Code version:
  Firefox 145.0.1
• Extension version:
  1.5.0

[rthomas320]

I also tested this scenario:

Steps to Reproduce
start the debugger to run the extension in debug
when the debug vs code window opens, use ctrl+shift+p to launch the data editor
pick a file to open
close the debug vs code window
close the original vs code window
open vs code
start the debugger to run the extension in debug
when the debug vs code window opens, use ctrl+shift+p to launch the data editor
pick a file to open

Expected Behavior
Data editor should open and and the file should open with the data displayed

Actual Behavior
Data editor opens but the file does not load and no data is displayed
The Java process shows as running in task manager

[lrbarber]

It looks like closing the entire window when the data editor is open -- using the top right X causes the problem. It seems that this exit path does not shut down the server used by the data editor.