[opt](staticstis) use count(1) for rowCount when scan full table #58153
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34374 ms |
TPC-DS: Total hot run time: 188035 ms |
ClickBench: Total hot run time: 27.27 s |
Contributor
Author
|
run feut |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run p0 |
Contributor
Author
|
run feut |
Jibing-Li
previously approved these changes
Nov 20, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
FE Regression Coverage ReportIncrement line coverage |
This reverts commit 9b950f6.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34210 ms |
TPC-DS: Total hot run time: 188041 ms |
ClickBench: Total hot run time: 27.42 s |
morrySnow
approved these changes
Nov 20, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Jibing-Li
approved these changes
Nov 20, 2025
Contributor
|
run cloud_p0 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
) ### What problem does this PR solve? when do sample, it will use table.getRowCount() as rowsCount, but the table.getRowCount() may be stale because it depend on BE's report, then it may occur rowsCount < ndv. Then when if 10 * rowsCount < ndv， the analyze sql will fail. Then the regression test statistics/analyze_stats.groovy is not stable, and cause error: ``` Exception: java.sql.SQLException: errCode = 2, detailMessage = Failed to analyze following columns:[id] Reasons: java.lang.RuntimeException: ColStatsData is invalid, skip analyzing. ('1763112020393--1-id',0,1763112019723,1763112020393,-1,'id',null,1,16,0,'1','201',64,'2025-11-14 17:41:14','105 :0.06 ;104 :0.06 ;103 :0.06 ;102 :0.06 ;101 :0.06 ;10 :0.06 ;9 :0.06 ;8 :0.06 ;7 :0.06 ;6 :0.06') at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129) at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122) at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953) at com.mysql.cj.jdbc.ClientPreparedStatement.execute(ClientPreparedStatement.java:371) at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321) at org.apache.doris.regression.util.JdbcUtils$_executeToList_closure1.doCall(JdbcUtils.groovy:47) at sun.reflect.GeneratedMethodAccessor33.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343) at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328) at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:279) ``` so when do sample and scan whole table, we use count(1) to represent rowsCount. Notice that this replace will not increase the excute cost, because the staticstic sql has contained `count(1)`.
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when do sample, it will use table.getRowCount() as rowsCount, but the table.getRowCount() may be stale because it depend on BE's report, then it may occur rowsCount < ndv.
Then when if 10 * rowsCount < ndv， the analyze sql will fail.
Then the regression test statistics/analyze_stats.groovy is not stable, and cause error:
so when do sample and scan whole table, we use count(1) to represent rowsCount.
Notice that this replace will not increase the excute cost, because the staticstic sql has contained
count(1).Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)